912411 - Remove assorted jsapi.h includes

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Removed some jsapi.h includes in Gecko.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Move JSID_{VOID,EMPTY}HANDLE from jsapi.{h,cpp} to Id.{h,cpp}.

I thought about doing this when I created Id.{h,cpp}, but deferred.  But now I
see that it will allow AccessCheck.h to not depend on jsapi.h.

I also moved them into the global namespace, because JS::JS_* is stoopid.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove lots of jsapi.h includes in SpiderMonkey.

After this, the only .h files within js/src/ that include jsapi.h are jsexn.h
and vm/String.h.  That's nice.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 799370 [details] [diff] [review]
(part 1) - Removed some jsapi.h includes in Gecko.

r=me

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 799879 [details] [diff] [review]
(part 3) - Remove lots of jsapi.h includes in SpiderMonkey.

ooc: does this mean all these .cpps (which no longer #include jsapi.h explicitly) don't include jsapi.h transitively at all?

Comment 6

[Nicholas Nethercote [inactive]]

> ooc: does this mean all these .cpps (which no longer #include jsapi.h
> explicitly) don't include jsapi.h transitively at all?

Alas, no.  jsapi.h is included by vm/String.h, which is included by vm/ObjectImpl.h, which is included by jsobj.h and vm/Shape.h, which are both included all over the place.  #include is truly a ridiculous mechanism.  But we're heading in the right direction :)

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5414483004cf
https://hg.mozilla.org/integration/mozilla-inbound/rev/053f6a2c5e29
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1262e2db291

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5414483004cf
https://hg.mozilla.org/mozilla-central/rev/053f6a2c5e29
https://hg.mozilla.org/mozilla-central/rev/c1262e2db291