Closed Bug 912437 Opened 11 years ago Closed 11 years ago

[BB] Change the disabled state for list elements row

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vicky, Assigned: arnau)

Details

(Whiteboard: visual design, visual-tracking)

Attachments

(4 files)

The current status shows the disabled state of a list row with a darker rectangle greying out the text. This is missleading as in plain white backgrounds this looks more like a highlight than a disabled state.
Assignee: nobody → arnau
Whiteboard: visual design, visual-tracking
Which is the priority for this? We can add it to the refactor maybe.
Could you please provide a visual showing how this should look like, or the opacity value? Thanks!
Flags: needinfo?(vpg)
Attached image Correct margins
I'd say margins are not well implemented here, but i'm not sure if this is part of the same BB (i assume yes, the "lists" one). We should leave 15px for dividers and 30px for content.
Sergi should be able to provide it as he is working with this components. It should be a disabled state that does not mean changing the background color but softening the content of what needs to be disabled. 

Also, regarding margins, the text content should be 30px indented, but the elements are supposed to sit within 15 px to the border, so they line up with the borders but the text inside -in the case of the buttons- lines up with the rest of text.

Hope this helps clarify.
Flags: needinfo?(vpg)
I'm not a big fan of playing with transparency levels in CSS. It may have an impact in performance and we may also have problems depending on the background color we use (in this case the background is white, but as far as this is a BB, any developer may be using it with a different background color, or even a picture, so it may impact its legibility). 

That said, i also agree using the disabled state as we have it right now is a little bit confusing, and it seems like you have something selected.

Let's try to use a transparency of an 80% for disabled components in a list (that's the transparency level we've been using for some other components in the past). It's important to keep the divider lines 100% opaque, and not apply that 80% transparency value to them.

Thanks!
Sergi, you mean 20% right?
Flags: needinfo?(sergiov)
Attached file patch in github
I don't like using >* but I think is the best way to change the opacity without affecting the border color.
Attachment #801563 - Flags: review?(igonzaleznicolas)
This patch will only change opacity, there is another bug opened to change margins in lists BB (875267)
(In reply to Arnau March from comment #6)
> Sergi, you mean 20% right?

Well, yes. 80% transparent, so 20%

Thanks!
Flags: needinfo?(sergiov)
Comment on attachment 801563 [details]
patch in github

you got my r+ :D Awesome work!
Attachment #801563 - Flags: review?(igonzaleznicolas) → review+
(In reply to Ismael Gonzalez [:basiclines] from comment #10)
> Comment on attachment 801563 [details]
> patch in github
> 
> you got my r+ :D Awesome work!

Hey Arnau, since this patch has been R+ can it land?
Flags: needinfo?(arnau)
Eric, 
I forgot to close this bug. Is already merged in gaia master: b360c6e2979e99e7eab14cd2131bce5cdc5be058
Thanks for the follow up!
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(arnau)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: