912443 - cache miss and script error when installing apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Andrew Williamson [:eviljeff]]

https://marketplace.firefox.com/search?q=predict+ball

Predict ball is there twice (note with different developers) but this is seemingly causing 

[12:03:37.176] TypeError: a is undefined @ https://marketplace.cdn.mozilla.net/media/fireplace/js/include.js?b=2c3f67a-5226326e:1
[12:03:37.175] "[model] app cache miss for key predict-ball"
[12:03:37.176] "[amd] Script error." "https://marketplace.cdn.mozilla.net/media/fireplace/js/include.js?b=2c3f67a-5226326e" 0

which breaks install for all search results (not just predict ball).

Marking as critical as I don't know how many apps/search strings this is hitting.

Comment 1

[Andrew Williamson [:eviljeff]]

Further details -
* I can only replicate this so far on Aurora, not Beta.
* hitting refresh sometimes helps, sometimes causes the issue.
* This app's detail page: https://marketplace.firefox.com/app/ip/ is throwing the exact same error

Comment 2

[Mathieu Pillard [:mat]]

I can reproduce both with Aurora and Firefox 23, desktop.

Comment 3

[Rob Hudson [:robhudson]]

Looking at the raw JSON output, there are two distinct apps named "Predict Ball".

1. ID=449966
2. ID=462654

According to the database the first one is deleted and should have been removed from the search index, but apparently was not.

I've asked for prod to be reindexed to clear this up.

Comment 4

[Andrew Williamson [:eviljeff]]

thanks Rob.
Revising the bug summary now its clear the duplicated search result was unrelated to non-installable issue.

Comment 5

[Andrew Williamson [:eviljeff]]

I can near-reliably replicate by:
1) running https://marketplace.firefox.com/search?q=predict+ball
2) apps should install
3) hit refresh
4) script error should happen.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Yeah, these are definitely two different apps (notice the different developer names below the app names). CC-ing Basta for Fireplace troubleshooting.

Comment 7

[Andrew Williamson [:eviljeff]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #6)
> Yeah, these are definitely two different apps (notice the different
> developer names below the app names). 

The reindex fixed the two apps issue.  I can still replicate the js and non-install error regardless though.

Comment 8

[Matt Basta [:basta]]

I'd need full logs to be able to debug what the problem is. The cache miss explains why there's a TypeError, but I don't know why you're getting a cache miss.

Comment 9

[Andrew Williamson [:eviljeff]]

submitted: 5f84d (I can't see anything particularly more informative than the bit I posted though tbh)

Comment 10

[Matt Basta [:basta]]

Just what I needed to see.

https://github.com/mozilla/fireplace/commit/41580e6e578b214d6f1bdf8dd75b264f472a4988

Let me know if that does anything, once -dev updates.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

I couldn't and can't reproduce. eviljeff - please reopen if this isn't fixed - thanks!

Comment 12

[Andrew Williamson [:eviljeff]]

I didn't try on -dev (the app wasn't available for me to try the same search) so I've no way of trying to reproduce until this hits prod unfortunately