Closed
Bug 912450
Opened 12 years ago
Closed 12 years ago
Stop exporting WebRTC symbols from libxul
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ted, Assigned: jesup)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The WebRTC build defines WEBRTC_EXPORT:
http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/build/common.gypi#328
Which leads to WEBRTC_DLLEXPORT being defined as a dllexport:
http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/common_types.h#22
Which leads to a whole swath of WebRTC code being exported from libxul:
http://mxr.mozilla.org/mozilla-central/ident?i=WEBRTC_DLLEXPORT
We should stop doing this.
|
Assignee | |
Comment 1•12 years ago
|
||
Ran a win32 Try with mochitest-3 and crashtests, green
|
|
Assignee | |
Updated•12 years ago
|
Attachment #799568 -
Flags: review?(ted)
|
Reporter | |
Updated•12 years ago
|
Attachment #799568 -
Flags: review?(ted) → review+
|
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → rjesup
|
|
Assignee | |
Comment 2•12 years ago
|
||
Target Milestone: --- → mozilla26
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•