Closed Bug 912450 Opened 6 years ago Closed 6 years ago

Stop exporting WebRTC symbols from libxul

Categories

(Core :: WebRTC, defect)

22 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: ted, Assigned: jesup)

Details

Attachments

(1 file)

The WebRTC build defines WEBRTC_EXPORT:
http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/build/common.gypi#328

Which leads to WEBRTC_DLLEXPORT being defined as a dllexport:
http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/common_types.h#22

Which leads to a whole swath of WebRTC code being exported from libxul:
http://mxr.mozilla.org/mozilla-central/ident?i=WEBRTC_DLLEXPORT

We should stop doing this.
Ran a win32 Try with mochitest-3 and crashtests, green
Attachment #799568 - Flags: review?(ted)
Attachment #799568 - Flags: review?(ted) → review+
Assignee: nobody → rjesup
https://hg.mozilla.org/mozilla-central/rev/7ccebf05488c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.