[Dialer] Invalid (zls) ID for section element on outgoing call screen

RESOLVED FIXED

Status

Firefox OS
Gaia::Dialer
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: zac, Assigned: etienne)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 799482 [details]
source html of outgoing call screen

In an outgoing call, the section element that contains outgoing call information contains an element with a zls id attribute.

In the attached source code, the offending line is line 72.

As the ID is a zls I am getting the impression that something is supposed to be setting an ID to it but failing to do so somewhere.


STR
1. Create a contact with first name, surname and phone number.
2. Load the contact details page in Contacts app
3. Tap 'call' to call the Contact
4. Wait for call to initiate
5. Dump/capture HTML
(Assignee)

Comment 1

4 years ago
We can have more than one call, so an ID won't cut it.

We can add a class to every handled call node pretty easily if this would solve your issue (we don't need it for anything else).
(Reporter)

Comment 2

4 years ago
Yes that would resolve the problem etienne, thanks.

This is making our automation tricky because there's no trustworthy locator.
(Assignee)

Comment 3

4 years ago
Taking then :)
Assignee: nobody → etienne
(Assignee)

Comment 4

4 years ago
Created attachment 799515 [details]
Pointer to gaia PR

Simple enough :)
Attachment #799515 - Flags: review?(anthony)
Comment on attachment 799515 [details]
Pointer to gaia PR

I'd rather add the class when we copy the node so that this class only represents real calls.
Attachment #799515 - Flags: review?(anthony) → review-
(Assignee)

Comment 6

4 years ago
[:facepalm] indeed, it would be much better for the purpose of this bug :)
(Assignee)

Comment 7

4 years ago
Comment on attachment 799515 [details]
Pointer to gaia PR

ready for the new round, thanks for saving my ass!
Attachment #799515 - Flags: review- → review?(anthony)

Updated

4 years ago
Attachment #799515 - Flags: review?(anthony) → review+
(Assignee)

Comment 8

4 years ago
https://github.com/mozilla-b2g/gaia/commit/6b5420e59ddc0399735e09b177bc22902cdc6fb2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.