912525 - [Email] Attachment icon missing in inbox from incoming email

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: Email Screenshot HD_Attachment.png

Hi Pavel, 

The attachment icon is missing from the inbox from incoming email messages. This is happening in HD only. See attached screenshot for reference. 

Thanks

Comment 1

[Amy Lee [:amylee] UX]

Attachment: Email_Screenshot HD_Attachment.png

Screenshot

Comment 2

[Amy Lee [:amylee] UX]

Attachment: Email-Screenshot-HD.png

Hi, 

The previous attachment seemed to have errors. I've reattached the screenshot.

Comment 3

[Amy Lee [:amylee] UX]

Attachment: actionicon_email_attachment.png

I've included the attachment icon if needed.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

There was a minor CSS error made in bug 830644 it looks like.  I have a fix reviewed by jrburke, gonna land momentarily.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/12109
https://github.com/mozilla-b2g/gaia/commit/efd21eddc030c2232b2e4707650995ed7714c38e

QA, can you make sure the paperclip icon shows up on v1-train (v1.1) normal builds?

Comment 7

[William Hsu [:whsu]]

The V1-train(V1.1.0) had the paperclip icon. So, I think V1-TRAIN doesn't need this patch.
Thank you. Attaching the screenshot.

* Test build:
 - Gaia:     8b20ff956f8e366a17a7ef5f64935a6a6a8cb0c0
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/bebaca30ea30
 - BuildID   20130916041201
 - Version   18.0


By the way, I still cannot verify it on master build because PVT master build was broken.
Even if I build a local build, the email app cannot work.
I am not sure which patch impacted the e-mail app.

Comment 8

[William Hsu [:whsu]]

Attachment: Paper clip

Comment 9

[lecky]

Hi Wayne :
 Please help us to push to merge this case into V1.1 HD. It blocked the Helix Device .If you can not resolve it , please get the authorization from carrier.

Comment 10

[William Hsu [:whsu]]

Hi, Lecky,

Thanks for your reminder.


-------------------------------------------------------------------------
Hi, Andrew,

Could I have your help? Could you please uplift this patch to v1.1.0 hd?
"v1.1.0" build can display this icon but "v1.1.0 hd" cannot display this icon.

* Test build:
 - Gaia:     8059864bd278645ab5d2598b5ed595154136c253
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/710e8b760ccb
 - BuildID   20130917042211
 - Version   18.0

* Result:
  No paperclip icon

Attaching the screenshot.

Many thanks!

Comment 11

[William Hsu [:whsu]]

Attachment: Paperclip

Comment 12

[Andrew Sutherland [:asuth] (he/him)]

I (or anyone) can land it on the branch once it's blocking-b2g=hd+, which it should be.  needinfo'ing doliver too since I think he can also authorize it.

Comment 13

[Andrew Sutherland [:asuth] (he/him)]

Uplifted; patch did not apply cleanly because of the filename change so I manually re-applied the super tiny change.  I used vim so there was no end-of-file newline change this time, which doesn't really matter either way.

landed on gaia/v1.1.0hd:
https://github.com/mozilla-b2g/gaia/pull/12306
https://github.com/mozilla-b2g/gaia/commit/a5a7c5b23c02b99b64825676cffebc8639c264df

Comment 14

[William Hsu [:whsu]]

Hi, Andrew,

Thanks for your prompt help!
I cannot reproduce this bug on V1.1.0 hd branch.

* Test Build:
 - Gaia:     7859b08b221463e0c5559034ab151747af6eb038
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/8c326236a729
 - BuildID   20130924042203
 - Version   18.0


Attaching the screenshot.

Comment 15

[William Hsu [:whsu]]

Attachment: V1.1.0 hd - Paper clip

Comment 16

[William Hsu [:whsu]]

--------- Remove "VERIFYME" ---------