[Contacts] Preserve givenName and familyName of the new or being edited contact when merging.

RESOLVED FIXED

Status

Firefox OS
Gaia::Contacts
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: salva, Assigned: Jose Manuel Cantera)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 affected)

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(1 attachment)

When editing a contact or creating a new one and merging with other suggested contacts already on the device, the merging algorithm should preserve given name and family name of the contact being edited or created.
Sorry Ayman if I bother you with this topic again but we split our previous efforts changing the merge algorithms in several bugs to be more specific and this is here to ask for your blessings ,)

This is the behaviour we talked about in Skype so I would appreciate if you can leave a comment saying you agree and why.

Thank you.
Flags: needinfo?(aymanmaat)

Comment 2

4 years ago
(In reply to Salvador de la Puente González [:salva] from comment #1)
> Sorry Ayman if I bother you with this topic again but we split our previous
> efforts changing the merge algorithms in several bugs to be more specific
> and this is here to ask for your blessings ,)
> 
> This is the behaviour we talked about in Skype so I would appreciate if you
> can leave a comment saying you agree and why.
> 
> Thank you.

Your welcome to bother me with the topic all day long Salva - its my job to be bothered by it ;)

Yes as discussed over Skype this is a very pragmatic proposal. The theory behind it is that if the user is actively creating a new contact or editing an existing contact the contact that is being created or edited is King. That is to say that it is reasonable to surmise that the created / edited contact is the contact that holds the information that is newer/fresher/more up to date/important to the end user because it is the one being created / updated. In view of this it is this contact whose information should be presented when, upon editing being completed, duplicates found and merge initiated, there is a conflict in the givenName or familyName fields between this contact and the contact that is being merged into it. 

Lets not forget that there is a safety net in place. The user is presented with the list of contacts that will be merged into the contact that has been created or edited. Therefore they have visibility of the name fields of the proposed contacts to merge and can actively prevent them merging by deselecting them.

This has by blessing, now go forth and code in peace Salve :)
Flags: needinfo?(aymanmaat)

Updated

4 years ago
Whiteboard: [u=commsapps-user c=contacts p=0 s=v1.2-features-sprint-4]
(Assignee)

Updated

4 years ago
Assignee: nobody → jmcf
(Assignee)

Comment 3

4 years ago
Created attachment 800001 [details]
11941.html
Attachment #800001 - Flags: review?(salva)

Updated

4 years ago
Whiteboard: [u=commsapps-user c=contacts p=0 s=v1.2-features-sprint-4] → [u=commsapps-user c=contacts p=0]
Comment on attachment 800001 [details]
11941.html

Very nice patch. Thank you!
Attachment #800001 - Flags: review?(salva) → review+
(Assignee)

Comment 5

4 years ago
https://github.com/mozilla-b2g/gaia/commit/feec44b1b8ce07bbad16cf713c287493ad1322ae
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
status-b2g-v1.2: --- → affected
You need to log in before you can comment on or make changes to this bug.