912560 - many "warning: '__STDC_FORMAT_MACROS' macro redefined"

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Dana Keeler (she/her) [:keeler]]

Compiling what looks like the libs subtier in media/webrtc, I'm getting tons of these warnings printed:

13:23.36 ccsip_task.o
13:23.36 In file included from <built-in>:162:
13:23.43 In file included from <command line>:49:
13:23.43 ../../../../mozilla-config.h:211:9: warning: '__STDC_FORMAT_MACROS' macro redefined
13:23.43 #define __STDC_FORMAT_MACROS
13:23.43         ^
13:23.43 <command line>:40:9: note: previous definition is here
13:23.43 #define __STDC_FORMAT_MACROS 1
13:23.43         ^
13:23.43 1 warning generated.

This is with clang 3.3

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

On a B2G build, I'm getting this on basically every file (not just media/webrtc files)

widget/gonk/libui/Unicode.h sets it to 1 and causes the warnings
gfx/angle/src/compiler/preprocessor/Tokenizer.cpp also sets it to 1

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Oops, that's STDC_LIMIT_MACROS with gonk.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

see bug 911359

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I also see this when compiling WebRTC on Mac.

Comment 5

[Hubert Figuiere [:hub]]

(In reply to Randell Jesup [:jesup] from comment #2)
> Oops, that's STDC_LIMIT_MACROS with gonk.

And that was fixed with bug 911359 and I thought would fix this, but I too confused macros. Patch soon.

Comment 6

[Hubert Figuiere [:hub]]

Attachment: Bug 912560 - WebRTC may define __STDC_FORMAT_MACROS on the command line

Proposed fix. You might need to do |touch configure| to force configure to be re-run. Only testing on a FxOS build for now.

Comment 7

[Jeff Walden [:Waldo]]

Hmm, why isn't mozilla-config.h included first for WebRTC files?

Comment 8

[Hubert Figuiere [:hub]]

I think the defines on the command line take precedence.

Comment 9

[Hubert Figuiere [:hub]]

but said defines are BEFORE the -include ../../../../../../mozilla-config.h in the command line.

Comment 10

[Hubert Figuiere [:hub]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7599a4f3e17

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d7599a4f3e17