Closed
Bug 912560
Opened 11 years ago
Closed 11 years ago
many "warning: '__STDC_FORMAT_MACROS' macro redefined"
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: keeler, Assigned: hub)
Details
(Whiteboard: [c= p=1 s= u=])
Attachments
(1 file)
592 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Compiling what looks like the libs subtier in media/webrtc, I'm getting tons of these warnings printed: 13:23.36 ccsip_task.o 13:23.36 In file included from <built-in>:162: 13:23.43 In file included from <command line>:49: 13:23.43 ../../../../mozilla-config.h:211:9: warning: '__STDC_FORMAT_MACROS' macro redefined 13:23.43 #define __STDC_FORMAT_MACROS 13:23.43 ^ 13:23.43 <command line>:40:9: note: previous definition is here 13:23.43 #define __STDC_FORMAT_MACROS 1 13:23.43 ^ 13:23.43 1 warning generated. This is with clang 3.3
Comment 1•11 years ago
|
||
On a B2G build, I'm getting this on basically every file (not just media/webrtc files) widget/gonk/libui/Unicode.h sets it to 1 and causes the warnings gfx/angle/src/compiler/preprocessor/Tokenizer.cpp also sets it to 1
Comment 2•11 years ago
|
||
Oops, that's STDC_LIMIT_MACROS with gonk.
Comment 3•11 years ago
|
||
see bug 911359
I also see this when compiling WebRTC on Mac.
OS: Linux → All
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #2) > Oops, that's STDC_LIMIT_MACROS with gonk. And that was fixed with bug 911359 and I thought would fix this, but I too confused macros. Patch soon.
Assignee: nobody → hub
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•11 years ago
|
||
Proposed fix. You might need to do |touch configure| to force configure to be re-run. Only testing on a FxOS build for now.
Assignee | ||
Updated•11 years ago
|
Attachment #808642 -
Flags: review?(ted)
Comment 7•11 years ago
|
||
Hmm, why isn't mozilla-config.h included first for WebRTC files?
Assignee | ||
Comment 8•11 years ago
|
||
I think the defines on the command line take precedence.
Assignee | ||
Comment 9•11 years ago
|
||
but said defines are BEFORE the -include ../../../../../../mozilla-config.h in the command line.
Updated•11 years ago
|
Attachment #808642 -
Flags: review?(ted) → review+
Updated•11 years ago
|
Whiteboard: [c= p= s= u=]
Assignee | ||
Updated•11 years ago
|
Whiteboard: [c= p= s= u=] → [c= p=1 s= u=]
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7599a4f3e17
https://hg.mozilla.org/mozilla-central/rev/d7599a4f3e17
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•