Closed Bug 912567 Opened 7 years ago Closed 7 years ago

GenerationalGC: JSCompartment::newTypeObjects needs post-barrier

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch workInProgress (obsolete) — Splinter Review
The newTypeObjects set is keyed based partly on a prototype object, which may be moved by GGC.  Therefore it needs a postbarrier to rekey any entry based on a prototype in the nursery.
Summary: GenerationalGC: Compartment::newTypeObjects needs post-barrier → GenerationalGC: JSCompartment::newTypeObjects needs post-barrier
Assignee: general → jcoppeard
Blocks: 673454
Attached patch 1 - split-rekeySplinter Review
One thing that came up is the the hashtable rekey() methodOnly only worked where the Key type was the same as Lookup, which is not the case here.

This patch split rekey() into rekeyIfMoved() (which does the same as before) and rekeyAs(), which always rekeys and takes separate Lookup and Key arguments.
Attachment #799574 - Attachment is obsolete: true
Attachment #807158 - Flags: review?(terrence)
Attachment #807158 - Attachment description: split-rekey → 1 - split-rekey
This patch adds a postbarrier for newTypeObjects.
Attachment #807161 - Flags: review?(terrence)
Comment on attachment 807158 [details] [diff] [review]
1 - split-rekey

Review of attachment 807158 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! r=me
Attachment #807158 - Flags: review?(terrence) → review+
Comment on attachment 807161 [details] [diff] [review]
2 - getNewType-post-barrier

Review of attachment 807161 [details] [diff] [review]:
-----------------------------------------------------------------

Sending the review over to Brian.
Attachment #807161 - Flags: review?(terrence) → review?(bhackett1024)
Comment on attachment 807161 [details] [diff] [review]
2 - getNewType-post-barrier

Review of attachment 807161 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.
Attachment #807161 - Flags: review?(bhackett1024) → review+
You need to log in before you can comment on or make changes to this bug.