GenerationalGC: JSCompartment::newTypeObjects needs post-barrier

RESOLVED FIXED in mozilla27

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 799574 [details] [diff] [review]
workInProgress

The newTypeObjects set is keyed based partly on a prototype object, which may be moved by GGC.  Therefore it needs a postbarrier to rekey any entry based on a prototype in the nursery.
(Assignee)

Updated

5 years ago
Summary: GenerationalGC: Compartment::newTypeObjects needs post-barrier → GenerationalGC: JSCompartment::newTypeObjects needs post-barrier
(Assignee)

Updated

5 years ago
Assignee: general → jcoppeard
(Assignee)

Updated

5 years ago
Blocks: 673454
(Assignee)

Comment 1

5 years ago
Created attachment 807158 [details] [diff] [review]
1 - split-rekey

One thing that came up is the the hashtable rekey() methodOnly only worked where the Key type was the same as Lookup, which is not the case here.

This patch split rekey() into rekeyIfMoved() (which does the same as before) and rekeyAs(), which always rekeys and takes separate Lookup and Key arguments.
Attachment #799574 - Attachment is obsolete: true
Attachment #807158 - Flags: review?(terrence)
(Assignee)

Updated

5 years ago
Attachment #807158 - Attachment description: split-rekey → 1 - split-rekey
(Assignee)

Comment 2

5 years ago
Created attachment 807161 [details] [diff] [review]
2 - getNewType-post-barrier

This patch adds a postbarrier for newTypeObjects.
Attachment #807161 - Flags: review?(terrence)
Comment on attachment 807158 [details] [diff] [review]
1 - split-rekey

Review of attachment 807158 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! r=me
Attachment #807158 - Flags: review?(terrence) → review+
Comment on attachment 807161 [details] [diff] [review]
2 - getNewType-post-barrier

Review of attachment 807161 [details] [diff] [review]:
-----------------------------------------------------------------

Sending the review over to Brian.
Attachment #807161 - Flags: review?(terrence) → review?(bhackett1024)
Comment on attachment 807161 [details] [diff] [review]
2 - getNewType-post-barrier

Review of attachment 807161 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.
Attachment #807161 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/58de1d903b6f
https://hg.mozilla.org/mozilla-central/rev/104bd5bd8154
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.