912567 - GenerationalGC: JSCompartment::newTypeObjects needs post-barrier

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: workInProgress

The newTypeObjects set is keyed based partly on a prototype object, which may be moved by GGC.  Therefore it needs a postbarrier to rekey any entry based on a prototype in the nursery.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: 1 - split-rekey

One thing that came up is the the hashtable rekey() methodOnly only worked where the Key type was the same as Lookup, which is not the case here.

This patch split rekey() into rekeyIfMoved() (which does the same as before) and rekeyAs(), which always rekeys and takes separate Lookup and Key arguments.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: 2 - getNewType-post-barrier

This patch adds a postbarrier for newTypeObjects.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 807158 [details] [diff] [review]
1 - split-rekey

Review of attachment 807158 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! r=me

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 807161 [details] [diff] [review]
2 - getNewType-post-barrier

Review of attachment 807161 [details] [diff] [review]:
-----------------------------------------------------------------

Sending the review over to Brian.

Comment 5

[Brian Hackett [Laid off!]]

Comment on attachment 807161 [details] [diff] [review]
2 - getNewType-post-barrier

Review of attachment 807161 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.

Comment 6

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58de1d903b6f
https://hg.mozilla.org/integration/mozilla-inbound/rev/104bd5bd8154

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/58de1d903b6f
https://hg.mozilla.org/mozilla-central/rev/104bd5bd8154