Closed
Bug 912578
Opened 12 years ago
Closed 12 years ago
reload the my-makes panel every time "my makes" is clicked
Categories
(Webmaker Graveyard :: Login, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: michiel)
Details
Attachments
(1 file)
right now we let tools set the "my makes" iframe URL on login, and then the content stays the same unless userBar.updateMakes() is called by the tool. This leads to problems when publishing a make, which then doesn't show up in the "my makes" panel.
It's nicer if sso-ux takes care of this by making the my-makes link reload the panel content every time it is opened.
Attachment #799606 -
Flags: review?(jon)
Attachment #799606 -
Flags: review?(jon) → review?(kieran.sedgwick)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 799606 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/154
She's a keeper.
Attachment #799606 -
Flags: review?(kieran.sedgwick) → review+
|
||
Comment 3•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/login.webmaker.org
https://github.com/mozilla/login.webmaker.org/commit/f9fa5d361a2a43e6d654078e61bb7ca75c39f1a9
Merge pull request #154 from Pomax/bug912578
added reload-on-click for the my makes link
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•