912681 - Modify AOL UK Repack Configuration

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect, P3)

Description

[brian ellis]

Attachment: repack_existing_config_changes_for_new_aouk.patch

Build to test for AOL UK.  There are two files - one is the toolbar files and the other are new files for the toolbar (I forgot to commit those with the first run).

Comment 1

[brian ellis]

Attachment: repack_config_changes_for_aoluk.diff

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 799737 [details] [diff] [review]
repack_config_changes_for_aoluk.diff

This attachment is telling me that the binary components have changed, but I don't see new versions of those zip files included in the other patch attached to this bug.

How did you generate the other patch? 

For patches involving binary files, I believe you need to either use the --git option to hg diff, i.e. |hg diff --git|. 

The better method IMO is to commit your change locally and then use |hg export|

Comment 4

[brian ellis]

Attachment: new_aoluk_toolbar.patch

Comment 5

[brian ellis]

I think I fixed my error.  Before I hadn't committed the new files until after I created the patch.  I have recommitted the files and attached the new patch.  Let me know if it is better.

Comment 6

[Chris Cooper [:coop] (he/him)]

Comment on attachment 800991 [details] [diff] [review]
new_aoluk_toolbar.patch

Replied via email, but recording here for posterity too.

re: the new patch - it applies correctly *however* it still lists a
bunch of zip files in a widgets/ subdir of the extension. Neither the
widgets/ subdir nor the zip files themselves exist in our configs:

https://hg.mozilla.org/build/partner-repacks/file/8702ad2678c9/partners/aol_uk/distribution/extensions/%7B12e57d18-f8f7-4b76-af63-605365ab88ec%7D

Firefox 24.0 isn't final yet, but candidate builds are here if you
want to verify your config:

https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/24.0-candidates/build1/partner-repacks/aol_uk/

Comment 7

[brian ellis]

Hi - the widgets subdir is a new folder included with this toolbar.  The US build has those and the UK toolbar is just being brought up to date.  Here is the US config:  https://hg.mozilla.org/build/partner-repacks/file/83c2468936b1/partners/aol/distribution/extensions/%7B7affbfae-c4e2-4915-8c0f-00fa3ec610a1%7D

Is this proper way to include new subdirs?

Comment 8

[Chris Cooper [:coop] (he/him)]

To recap from email:

>> In reply to Brian:
>> I have tested the AOL custom browsers (US, UK and DE) and everything
>> is ok except that the default chrome search isn't set to AOL Search 
>> until the browser is restarted.  This was not the case in prior 
>> releases.  Can this be addressed?
>
> In reply to Mike:
> Can you clarify what you mean by "until the browser is restarted" 
> here?  All customizations should be applied on first run of a new 
> profile as well as on upgrade from a previous version (if installed 
> over a different build with the same version).  Can you provide 
> precise steps to reproduce, as I've heard no reports of this for 
> any other customized version.

Brian writes:

What I do is install a new custom AOL FF browser (not an upgrade).  After the installation is complete and the browser is loaded, the default search is not AOL search.  When I shut down and restart the browser, I see that browser search is then set to AOL search.

http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/24.0-candidates/build1/partner-repacks/aol/win32/en-US/Firefox%20Setup%2024.0.exe is what I use.

Comment 9

[brian ellis]

I see this on the Windows 7 platform and on a new profile or an existing profile that was running stock Firefox (I take this to  mean that I had removed Firefox before installing the custom browser)

Comment 10

[Mike Connor [:mconnor]]

Hi Brian, I'm now able to reproduce the issue locally.  It appears that the search plugin included in the base config (separate from the toolbar) is not valid XML, so Firefox can't install it.  What gets installed is the toolbar version of the search plugin, and it seems that doesn't get installed before the default pref is read and applied (which is why Yahoo! is the selected version).  I'm not sure if or why this worked previously, but the fix is fairly straightforward.  We'll get new builds to you ASAP.

Comment 11

[Mike Connor [:mconnor]]

https://hg.mozilla.org/build/partner-repacks/rev/c1ff445f0471 is now checked in:

* fix stray ampersands (special character in XML, have to use & if you want that character in a URL)
* fix encoding for DE so the description works correctly.

Coop or Ben, can you generate new builds here?

Comment 12

[Chris Cooper [:coop] (he/him)]

New builds are here for all aol repacks:

http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/24.0-candidates/build1/partner-repacks/