912690 - [Music] Music player 1px gap above timeline scrubber HD

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Amy Lee [:amylee] UX]

Attachment: MusicPlayer.png

Hi Pavel, 

There is a 1 pixel gap above the timeline scrubber. This is only seen in HD. Attached screenshot for reference.

Thanks

Comment 1

[Wayne Chang [:wchang]]

HD visual

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shots

Hey I can't reproduce the bug ... is this bug still active or we can mark this as WORKSFORME?

Comment 3

[Amy Lee [:amylee] UX]

Hey Pavel, 

I am still seeing the 1 pixel space. I can't update my build right now (it was last updated 1.5 weeks ago). Eric do you see the line in your device?

Comment 4

[Amy Lee [:amylee] UX]

Hey Pavel, 

I am still seeing the 1 pixel space. I can't update my build right now (it was last updated 1.5 weeks ago). Eric do you see the line in your device?

Comment 5

[Eric Pang [:epang] UX]

Attachment: Music Playing Screen

Hey Pavel, I just checked this now with today's build and still can see this occurring.  It looks like the generic album artwork is showing through at the bottom.  It usually more evident with the generic artwork is brighter in colour.  In the attached image you can see it clearly with the middle example.  I checked the sd device as well and it never seems to show up there.  Can you check again?  Where did you get your build, maybe mine is wrong? (https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-b2g18_v1_1_0_hd-helix/latest/) 
Thanks!

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 816259 [details]
shots

I'm still seeing this occur :(

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Oh now I saw the problem ... 
I think this one is related with the visuals. Can you provide me all sizes of them:

https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/scroll_bar_bg.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/scroll_bar_bg%401.5x.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/scroll_bar_bg%402x.png

thanks in advance :)

Comment 8

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #7)
> Oh now I saw the problem ... 
> I think this one is related with the visuals. Can you provide me all sizes
> of them:
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/
> scroll_bar_bg.png
> https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/
> scroll_bar_bg%401.5x.png
> https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/
> scroll_bar_bg%402x.png
> 
> thanks in advance :)

Hey Pavel, I looked at this closer and I don't think it's the scroll_bar_bg since the image is just a transparent gradient that doesn't make it up to the area of the issue.  Could it be that the generic album art is being sized 1px too big compared to the actual album art?  What do you think?  Are these the images that are used behind the actual album art work? https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/AlbumArt10_small%401.5x.png

Let me know and we can try sizing them down by a pixel :). Thanks!

Comment 9

[Wayne Chang [:wchang]]

Unblocking this given the low user impact polish nature of this bug, please fix and nominate for a future release.

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I can't reproduce this in today build
Eric?

Comment 11

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #10)
> I can't reproduce this in today build
> Eric?

I don't see this either anymore :).  Looks like we can close!  Thanks Pavel

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Eric :)