improve load source error messages

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
Firefox 26
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 799750 [details] [diff] [review]
source-errors.patch

The messages we get from the server when we try to load sources but it fails are pretty bad. We should improve them.

https://tbpl.mozilla.org/?tree=Try&rev=a698710ded25
Attachment #799750 - Flags: review?(past)
Comment on attachment 799750 [details] [diff] [review]
source-errors.patch

Review of attachment 799750 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/script.js
@@ +3769,5 @@
>          },
>          onStopRequest: function(aRequest, aContext, aStatusCode) {
>            if (!Components.isSuccessCode(aStatusCode)) {
> +            deferred.reject(new Error("Request failed in onStopRequest. url = " + url
> +                                      + ", status code = " + aStatusCode));

Wouldn't it be better to have something like "Request failed with status = 35 in onFooHandler for url = http://blah"?
Attachment #799750 - Flags: review?(past) → review+
Updated and pushed.

https://hg.mozilla.org/integration/fx-team/rev/a72b2b8b82df
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a72b2b8b82df
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.