Closed Bug 912702 Opened 6 years ago Closed 6 years ago

Minimize the #includes in content/media

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: Ehsan, Assigned: Ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Something's #defining version_major or version_minor?
(In reply to comment #4)
> Something's #defining version_major or version_minor?

Seems like it, but the question is, what code does that?  It surely is not in mozilla-central: <http://mxr.mozilla.org/mozilla-central/search?string=version_major&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central>
Yay!

hardware/libhardware/include/hardware/hardware.h:112:#define version_major module_api_version
Here's how this thing is pulled in:

/media/storage/moz/b2g-jb-emu/gecko/content/media/ogg/OggCodecState.h
../../../dist/include/mozilla/dom/HTMLMediaElement.h
../../../dist/include/mozilla/dom/TextTrack.h
../../../dist/include/nsDOMEventTargetHelper.h
../../../dist/include/nsEventListenerManager.h
../../../dist/include/nsGUIEvent.h
../../../dist/include/nsIWidget.h
../../../dist/include/mozilla/layers/LayersTypes.h
/media/storage/moz/b2g-jb-emu/frameworks/native/include/ui/GraphicBuffer.h
/media/storage/moz/b2g-jb-emu/frameworks/native/include/ui/ANativeObjectBase.h
/media/storage/moz/b2g-jb-emu/hardware/libhardware/include/hardware/gralloc.h
/media/storage/moz/b2g-jb-emu/hardware/libhardware/include/hardware/hardware.h
Fixing that is very difficult, since VideoSegment.h #includes ImageContainer.h which would transitively #include LayersTypes.h which #includes <ui/GraphicBuffer.h>.

I'm just going to go ahead with the #undef trick.
https://hg.mozilla.org/mozilla-central/rev/cb8146788ab1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.