Closed
Bug 912767
Opened 12 years ago
Closed 5 years ago
Tabs shouldn't handle bookmarking or thumbnail db.
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: wesj, Unassigned)
Details
Currently we methods in tab.java to add/remove/update the bookmark for the current tab. While it looks nice to write tab.addBookmark(), it also adds a coupling between the Tabs object and the databases that we don't really need.
i.e. callers can instead call:
BrowserDB.addBookmark(getContentResolver(), tab.getTitle(), tab.getUrl());
If we can get rid of this, we don't need to hold the appContext in each individual tab either.
|
||
Comment 1•12 years ago
|
||
Good mentor bug?
|
||
Comment 2•5 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
|
Assignee | |
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•