912843 - [Gallery] Partial back out of bug 903944 - Remove the local copy of the blob before opening an image

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Andre Graziani (:graziani)]

We should remove the workaround from bug 903944 once we have the bug 908432 fixed.

This is based on comments from these two bugs which say that the workaround in Gaia is considered expensive, and the new Gecko patch solves the problem.

The back out should be partial, because part of that also fixes bug 908126.

Comment 1

[Andre Graziani (:graziani)]

Attachment: Patch 1 - Partial back out of bug 903944

This patch backs out the workaround for the crash from bug 903944, and keeps the fixes related to small preview display.

Comment 2

[David Flanagan [:djf]]

Comment on attachment 799966 [details] [diff] [review]
Patch 1 - Partial back out of bug 903944

Review of attachment 799966 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks like it cleanly removes the workaround.  Thanks for coming back to this.

I looks like the gecko fix in bug 908432 has not been uplifted to b2g18, so don't uplift this to v1-train unless the gecko patch is uplifted first.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I think the plan is to take this. Requesting approval.

Comment 4

[Preeti Raghunath(:Preeti)]

Ben

Please provide risk analysis.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I didn't have anything to do with this patch really so I can't answer. David, can you help here? (https://bugzilla.mozilla.org/show_bug.cgi?id=908432#c1 is what I'm referring to).

Comment 6

[David Flanagan [:djf]]

Bug 903944 added a workaround for a gallery crash, and was uplifted to v1-train.

Bug 908432 fixed the underlying cause of the crash in gecko and has been uplifted to b2g-18.

This bug removes the workaround.  If we don't uplift it to v1-train, we'll be running an unnecessary workaround and the Gallery View activity will use more memory and be a little less responsive than it would be otherwise.

The risk here is that verifying that bug 903944 is still gone after removing the workaround will be difficult because it is a corner case only triggered by very specific images.  See https://bugzilla.mozilla.org/show_bug.cgi?id=903944#c35 for verification requirements.

Comment 7

[David Scravaglieri [:scravag]]

This bug comes late in the game. It seems we could live with it. Not a release blocker

Comment 8

[David Flanagan [:djf]]

Andre,

Even though this bug did not get uplift permission, it should still have landed to master. I'm setting needinfo on you just to bring that to your attention.

Closing this bug, however, because bug 917387 will remove the workaround on master and v1.2.

Comment 9

[Andre Graziani (:graziani)]

(In reply to David Flanagan [:djf] from comment #8)

Sorry, I should have uplifted it to master.
bug 917387 did that, so no more action is required for now.