javascript strict warnings in askSendFormat.js

VERIFIED FIXED

Status

MailNews Core
Composition
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: Henrik Gemal, Assigned: varada)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
Warning: redeclaration of var radioSelect
Source File: chrome://messenger/content/messengercompose/askSendFormat.js
Line: 96, Column: 12

build 20010717

Please add the following line to your prefs.js file, so we could avoid all the 
strict warning fixup...:
user_pref("javascript.options.strict", true);

Updated

17 years ago
QA Contact: sheelar → stephend

Updated

17 years ago
Assignee: ducarroz → varada
over to varada
Created attachment 43335 [details] [diff] [review]
Fix

Comment 3

17 years ago
r=kerz,sr=blake in irc
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
C:\moz_src\mozilla\mailnews\compose\resources\content>cvs commit -m "91285.  Jav
ascript strict warnings in askSendFormat.js r=kerz@netscape.com sr=blaker@netsca
pe.com" askSendFormat.js
Checking in askSendFormat.js;
/cvsroot/mozilla/mailnews/compose/resources/content/askSendFormat.js,v  <--  ask
SendFormat.js
new revision: 1.14; previous revision: 1.13
done
I shouldn't be QA for this, since I fixed it.  Henrik, would you mind verifying
this?
(Reporter)

Comment 6

17 years ago
fixed. No more javascript warnings in this file.
10.000 files to go...:(
Status: RESOLVED → VERIFIED
Sorry, re-opening this to provide a better fix.  My apologies to Varada for
side-stepping the normal process flow here.  I'll attach a new patch for this,
that declares the variable before it steps into the if/else clause.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Created attachment 43396 [details] [diff] [review]
New Patch
(Reporter)

Comment 9

17 years ago
r=gemal@gemal.dk on the new patch...
I'll need Varada's though, since it is his code (and I messed up on the first
patch). ;-(
(Assignee)

Comment 11

17 years ago
This was just an oversight.So  stephen feel free to sidestep me anytime you have
patches and fixes :-). 
r=varada.
The real fix was just checked in.  Again, I'm sorry about this, and will seek
module owner's approval in the future. :-(
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
Henrik will have to verify this when a respin comes out, since I fixed it.
QA Contact: stephend → gemal

Comment 14

17 years ago
Verified code fix
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.