If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

With apz enabled, clicking the bookmark button triggers double input events

RESOLVED FIXED in mozilla26

Status

()

Core
Widget: WinRT
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

26 Branch
mozilla26
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
STR:

1) enable apz
2) visit a page
3) click the bookmark button

result:

the button will depress indicating a bookmark was added, then a split second later return to it's normal state, indicating the bookmark was removed.

This may be a side effect of bug 907410 as well, since I have that in my patch queue.
(Assignee)

Comment 1

4 years ago
I think we need a fix to this before we turn on apz. Also checked, this isn't related to bug 907410.
Blocks: 898055
(Assignee)

Updated

4 years ago
Assignee: nobody → jmathies
(Assignee)

Comment 2

4 years ago
Created attachment 800179 [details] [diff] [review]
add feature selection support to GestureEventListener v.1
(Assignee)

Updated

4 years ago
Attachment #800179 - Flags: review?(bugmail.mozilla)
(Assignee)

Comment 3

4 years ago
We might come back to using this in time as we work on our input process but for the time being I'd prefer to rely on the built-in support we get from the Winrt GestureRecognizer class.
You don't actually need the changes to GestureEventListener* here, do you? Stubbing out the callbacks in MetroWidget should be sufficient. I'm a little leery of disabling pieces of the gesture code because it's easy to miss something and leave the internal state inconsistent.
(Assignee)

Comment 5

4 years ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> You don't actually need the changes to GestureEventListener* here, do you?
> Stubbing out the callbacks in MetroWidget should be sufficient. I'm a little
> leery of disabling pieces of the gesture code because it's easy to miss
> something and leave the internal state inconsistent.

I'm not a fan of the added overhead this creates, But I can live with it if you really don't want GestureEventListener configurable.
(Assignee)

Comment 6

4 years ago
Created attachment 800313 [details] [diff] [review]
stub out tap handlers
Attachment #800313 - Flags: review?(netzen)
(Assignee)

Updated

4 years ago
Attachment #800179 - Flags: review?(bugmail.mozilla)
Attachment #800313 - Flags: review?(netzen) → review+
(In reply to Jim Mathies [:jimm] from comment #5)
> I'm not a fan of the added overhead this creates, But I can live with it if
> you really don't want GestureEventListener configurable.

I'm not either, but I think the longer term solution is to move the detection for those tap events out of APZC-land and into gecko.
https://hg.mozilla.org/mozilla-central/rev/4b03903fb8f5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.