Closed Bug 912931 Opened 7 years ago Closed 7 years ago

With apz enabled, clicking the bookmark button triggers double input events

Categories

(Core Graveyard :: Widget: WinRT, defect)

26 Branch
x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(2 files)

STR:

1) enable apz
2) visit a page
3) click the bookmark button

result:

the button will depress indicating a bookmark was added, then a split second later return to it's normal state, indicating the bookmark was removed.

This may be a side effect of bug 907410 as well, since I have that in my patch queue.
I think we need a fix to this before we turn on apz. Also checked, this isn't related to bug 907410.
Blocks: 898055
Assignee: nobody → jmathies
Attachment #800179 - Flags: review?(bugmail.mozilla)
We might come back to using this in time as we work on our input process but for the time being I'd prefer to rely on the built-in support we get from the Winrt GestureRecognizer class.
You don't actually need the changes to GestureEventListener* here, do you? Stubbing out the callbacks in MetroWidget should be sufficient. I'm a little leery of disabling pieces of the gesture code because it's easy to miss something and leave the internal state inconsistent.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> You don't actually need the changes to GestureEventListener* here, do you?
> Stubbing out the callbacks in MetroWidget should be sufficient. I'm a little
> leery of disabling pieces of the gesture code because it's easy to miss
> something and leave the internal state inconsistent.

I'm not a fan of the added overhead this creates, But I can live with it if you really don't want GestureEventListener configurable.
Attachment #800313 - Flags: review?(netzen)
Attachment #800179 - Flags: review?(bugmail.mozilla)
Attachment #800313 - Flags: review?(netzen) → review+
(In reply to Jim Mathies [:jimm] from comment #5)
> I'm not a fan of the added overhead this creates, But I can live with it if
> you really don't want GestureEventListener configurable.

I'm not either, but I think the longer term solution is to move the detection for those tap events out of APZC-land and into gecko.
https://hg.mozilla.org/mozilla-central/rev/4b03903fb8f5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
OS: Windows 8 Metro → Windows 8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.