If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Localized itsatrap page for Hebrew (he) has a different HTML structure

NEW
Unassigned

Status

www.mozilla.org
L10N
4 years ago
4 years ago

People

(Reporter: AndreeaMatei, Unassigned)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

4 years ago
Our mozmill test for checking its-a-trap.html and its-an-attack.html pages after ignoring the warning makes use of 'main-feature' id, which [he] build does not have. 
The page loaded after ignoring the warning is:
http://www.mozilla.org/he/firefox/its-a-trap.html
You can replace "he" with other locales as well.

I've created a small testcase which checks all locales for that id and only [he] seems to miss it.
(In reply to Andreea Matei [:AndreeaMatei] from comment #0)
> Our mozmill test for checking its-a-trap.html and its-an-attack.html pages
> after ignoring the warning makes use of 'main-feature' id, which [he] build
> does not have. 

Not sure what the last sentence means, but that page is not part of the he (Hebrew?) build. It's the internal URL which we simply follow to that page.

> The page loaded after ignoring the warning is:
> http://www.mozilla.org/he/firefox/its-a-trap.html
> You can replace "he" with other locales as well.

Hm, the page looks somewhat busted. It's different to all the other ones. Not sure what the reason for that is. Pascal can you please have a look at when you are back on Monday? Thanks.
Flags: needinfo?(pascalc)
Summary: Localized page for [he] does not have the same structure → Localized itsatrap page for Hebrew (he) has a different HTML structure
I'm not sure I'm following

http://www.mozilla.org/it/firefox/its-a-trap.html
404 Page not found exactly as he (and all other locales)

http://www.mozilla.org/firefox/its-a-trap.html
It's ok and localized (for me in Italian), and that's what I expect to load for malware.

And those URLs are hard-coded in the source code
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/SafeBrowsing.jsm#148
Flags: needinfo?(pascalc)
That might be related to bug 906304. Somehow we get a redirect. Andreea, can you please check that in detail and give instructions how to reproduce that? Thanks.
Flags: needinfo?(andreea.matei)
(Reporter)

Comment 4

4 years ago
When you open http://www.mozilla.org/firefox/its-a-trap.html you get the warning with Reported Web Forgery!.
If you click Ignore this warning in the bottom-right side, you'll be redirected to:
http://www.mozilla.org/he/firefox/its-a-trap.html,

where [he] is replaced with the build locale you're on. It's a 404 page, but all the other locales except [he] have in it's html structure the "main-feature" id. 

Our test checks this id and we fail in [he] because is the only one that's missing it.
Flags: needinfo?(andreea.matei)
(In reply to Andreea Matei [:AndreeaMatei] from comment #4)
> where [he] is replaced with the build locale you're on. It's a 404 page, but
> all the other locales except [he] have in it's html structure the
> "main-feature" id. 

Now it's clearer. You're missing this piece of code in the page

<div id="main-feature">
    <h2>Hmmm, we’re having trouble finding that one.</h2>
</div>

he
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/he/404.html?revision=95242&view=markup

fr
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/de/404.html?revision=95242&view=markup

At this point I think I'll wait for Pascal to understand the best solution (there are other differences in the page, not just that div).
Flags: needinfo?(pascalc)
I have fixed the html on the 404 hebrew page in r119757, it is a non-maintained page and at some point we will switch to a bedrock powered template, so this specific id may change in the future. Also, shouldn't these urls be https? Is it hardcoded as http addresses in the chrome?
Flags: needinfo?(pascalc)
(In reply to Pascal Chevrel:pascalc from comment #6)
> template, so this specific id may change in the future. Also, shouldn't
> these urls be https? Is it hardcoded as http addresses in the chrome?

Nearly all of the "browser.safebrowsing.*" prefs are defined as HTTP in about:config. Might be worth changing that, indeed.

Updated

4 years ago
Component: Other → L10N
Product: Websites → www.mozilla.org
Version: unspecified → Production

Updated

4 years ago
Locale: he / Hebrew
You need to log in before you can comment on or make changes to this bug.