912953 - Invalidation fixes for elements with SVG filters

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

Attachment: part1, v1: apply the scroll offset transform to inactive layer managers for LAYER_SVG_EFFECTS, too

This fixes most invalidations on attachment 795171 [details] and is what Matt Woodrow suggested in bug 853699 comment 10.

Comment 1

[Markus Stange [:mstange]]

Attachment: part 2, v1: use consistent rounding for the scroll offset transform

This fixes invalidations that occurred on attachment 795171 [details] when scrolling it from positive into negative offsets.

Comment 2

[Markus Stange [:mstange]]

Attachment: part 3, v1: don't fluff out invalidation region from inactive layer manager

Sometimes, when scrolling an a page with an <svg> made up of multiple filtered elements, scrolling would invalidate 1x1 pixel boxes for each element, and this GetBounds() call would cause many more pixels to be repainted.

Comment 3

[Markus Stange [:mstange]]

Attachment: part 4, v1: empty rects shouldn't cause any invalidation

There are several places under nsSVGIntegrationUtils::AdjustInvalidAreaForSVGEffects where we convert rects between coordinate systems, round the result, and end up with a non-empty rect when the original rect was empty.

Comment 4

[Markus Stange [:mstange]]

Attachment: part 5, v1: more empty rect guards

Not sure if these are necessary, but I guess they wouldn't hurt.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/10464d3d16cb
https://hg.mozilla.org/mozilla-central/rev/b072e77cd907
https://hg.mozilla.org/mozilla-central/rev/801f91eeb1a1
https://hg.mozilla.org/mozilla-central/rev/7d460dd7724f
https://hg.mozilla.org/mozilla-central/rev/ee8ed9d3e90d