912988 - Use Thimble-like meta data publishing dialogue on first save

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[inactivate account for kate]

It would be nice if we integrated the same tag UI that is on thimble now into popcorn maker (http://dl.dropboxusercontent.com/u/29163874/Screenshots/li.png) 

It basically just displays tags as a list, adds new ones on ENTER or , keys and checks them for #.

Live demo on http://thimble-sandbox.herokuapp.com/

Comment 1

[Brett Gaylor [:brett]]

I'd like to see this implemented - as discussed in Friday Demos, this is a module that we should be able to drop in popcorn maker.  Scott, assigning to you.

Comment 2

[inactivate account for kate]

Look at:
https://github.com/mozilla/thimble.webmaker.org/blob/master/public/friendlycode/js/fc/ui/details-form.js#L39 https://github.com/mozilla/thimble.webmaker.org/blob/master/public/friendlycode/js/fc/ui/details-form.js#L135 https://github.com/mozilla/thimble.webmaker.org/blob/master/public/friendlycode/css/details-form.css

Comment 3

[inactivate account for kate]

HTML: https://github.com/mozilla/thimble.webmaker.org/blob/master/views/friendlycode/templates/details-form.html#L8

Comment 4

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/228

Boom.

I'll admit, this patch makes me feel we need to redo this editor a bit. Those other tabs are very empty and this main tab is getting crowded.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 810634 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/228

Adding new thumbnails doesn't add a thumbnail icon.

Also, when i go back to using a thumbnail via a thumbnail icon, I lose the http in the thumbnail dialog.

If it is easy, try adding the tag input next to "tags" dialog? Might be a quick and easy way to use space better. Not a huge deal though, we should probably file a ticket to do some small specific things to clean it up. I agree, it's not ideal and getting crouwded. Same with the main header.

Comment 6

[Matthew Schranz [:mjschranz]]

Comment on attachment 810634 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/228

Fixed up.

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 810634 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/228

Tags looking good.

Two slight quirks in thumbnail.

First, it doesn't keep the thumbnail on remixes, but I think it has always been that way so feel free to file that.

Second, loading a project on /edit, with a saved thumbnail, loses the default thumbnail. Thimble remembers it and I always have the option of going back to the default, but, I don't know how valuable that is, so, thoughts?

I think this is landable, but, gets an r- just in case you want to take it a bit further here.

Comment 8

[Matthew Schranz [:mjschranz]]

Comment on attachment 810634 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/228

Fixed.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/92b5d4feabd01b23a85698d4943bc25bf7545805
Fix Bug 912988 - Improved UI for thumbnail selection and tag adding

Comment 10

[Brett Gaylor [:brett]]

As discussed in IRC, I feel we need to prompt users at the time they click save to input this data.

Could we implement something similar to what thimble has http://dl.dropboxusercontent.com/u/29163874/Screenshots/li.png

And have this appear as a tooltip with the save button, that then populates the forms in the media tab.  Essentially we are funneling users to add this data because they currently are not.

Comment 11

[Brett Gaylor [:brett]]

Morphing this bug to reflect conversation today.

What we decided on was that during first save, you would see this dialogue:
http://dl.dropboxusercontent.com/u/29163874/Screenshots/li.png

The data entered there would then be input into project editor.  Subsequent saves would simply save, the dialogue would not appear.

Comment 12

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/266

new pr

Comment 13

[Scott [:thecount] Downe]

Comment on attachment 817917 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/266

canceling the dialog, then saving, it refuses to save.

I'm going to keep looking for bugs, but, no need to hold back the r-.

Comment 14

[Matthew Schranz [:mjschranz]]

Comment on attachment 817917 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/266

Updated. Fixed review comments and some UI bugs/quirks.

Comment 15

[Scott [:thecount] Downe]

Comment on attachment 817917 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/266

onward!

Comment 16

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/446c99a9ed35b6adbdf4f00ed8c1f846b6031421
Fix Bug 912988 - Use panel UI for better adoption of tag/thumbnail/description usage for first save

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/0fd7ccbd9652ed7056215ab489205f6087f8c52e
Bug 912988 - Include path was failing in staging. r=jbuck