912993 - cold_load_time regression of 200ms on datazilla

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Ben Kelly [:bkelly, not reviewing]]

On datazilla we see about a 200ms regression in cold_load_time across the board this morning on master:

  https://datazilla.mozilla.org/b2g/

The gecko revision did not change, so it appears to be something in gaia.  Current gaia range is:

Bad:  https://github.com/mozilla-b2g/gaia/commit/ec885264d885d877d68980c0227058231f18ad09
Good:  https://github.com/mozilla-b2g/gaia/commit/ec885264d885d877d68980c0227058231f18ad09

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I have asked to backout this patch for some others performance regression anyway. Can you check datazilla again in a few minutes with new builds without this change.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Vivien, which commit in particular are you referring to?  Is it ec88526?

I see now I messed up the range above.  The datazilla range actually covers a few commits.  It should be:

Bad:  https://github.com/mozilla-b2g/gaia/commit/ec885264d885d877d68980c0227058231f18ad09
Good:  https://github.com/mozilla-b2g/gaia/commit/d268227c2dcee18dc2568d0b10e347a18ad3e256

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Sorry, I see the reverts are already in the log.  I'm still waiting for my coffee to kick in...

Here are the revert commits:

  https://github.com/mozilla-b2g/gaia/commit/32644e1564ee75e2a60ca455e12f092901c03fed
  https://github.com/mozilla-b2g/gaia/commit/83c9c656955611bc28205511050ed6cb5ad7b4e5
  https://github.com/mozilla-b2g/gaia/commit/c9e9a31ae4fe9d85bc2eccfdc823b2f7f2aa6cd9

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Datazilla confirms this has been resolved.