[Calendar] Left align text in Calendar dropdowns

RESOLVED FIXED

Status

Firefox OS
Gaia::Calendar
P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: epang, Assigned: ivanovpavel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design, visual-tracking)

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
Created attachment 800152 [details]
Calendar Settings.jpg

Hi Pavel,

Can you check if these drop downs are using the building blocks?  The text should have a 30px left margin instead of being centered. Thanks!
Created attachment 800242 [details]
After patch screenshot
(Reporter)

Comment 2

4 years ago
(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 800242 [details]
> After patch screenshot

perfect, thanks Pavel!
Created attachment 800245 [details]
patch for Gaia/master
Attachment #800245 - Flags: review?(sjochimek)
I forgot to mention that the Calendar App don't use [BB] for the <select>, because of some custom logic.
(Reporter)

Comment 5

4 years ago
oh that's why they didn't change with the building block. Thanks!

Comment 6

4 years ago
Comment on attachment 800245 [details]
patch for Gaia/master

Landed on master: https://github.com/mozilla-b2g/gaia/commit/1c52330f5f19fd2d8333bb7dc7c95fcae44121f3
Attachment #800245 - Flags: review?(sjochimek) → review+

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.