Don't do memcpy in UnixSocketImpl::OnFileCanReadWithoutBlocking

RESOLVED FIXED in mozilla26

Status

()

Core
IPC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
mozilla26
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The is a big, fat 16KiB memcpy right in the middle of UnixSocketImpl::OnFileCanReadWithoutBlocking. Let's get rid of it.
It's actually 64 KiB.
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Created attachment 800247 [details] [diff] [review]
[01] Bug 912996: Fix whitespaces
Attachment #800247 - Flags: review?(kyle)
Created attachment 800248 [details] [diff] [review]
[02] Bug 912996: Remove memcpy when reading from Unix socket
Attachment #800248 - Flags: review?(kyle)
Tested on my Unagi.
Attachment #800247 - Flags: review?(kyle) → review+
Attachment #800248 - Flags: review?(kyle) → review+
Thanks!

https://hg.mozilla.org/integration/b2g-inbound/rev/329b5c56525a
https://hg.mozilla.org/integration/b2g-inbound/rev/8a03f671fd11

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=8a03f671fd11
https://hg.mozilla.org/mozilla-central/rev/329b5c56525a
https://hg.mozilla.org/mozilla-central/rev/8a03f671fd11
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.