913005 - Modifications to stl_wrappers rebuild anything that includes stl headers

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Considering the rule to build stl_wrappers depend on GLOBAL_DEPS, on top of the list of headers itself, that makes it happen an awful lot.

Comment 1

[(not currently active) Ted Mielczarek]

Can we at least make these FileAvoidWrite? They don't change much, should make most of the pain go away.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Avoid overwriting unchanged stl_wrappers

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 800172 [details] [diff] [review]
Avoid overwriting unchanged stl_wrappers

Review of attachment 800172 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/Makefile.in
@@ +112,5 @@
>  STL_WRAPPERS_SENTINEL = $(DIST)/stl_wrappers/sentinel
>  
>  $(STL_WRAPPERS_SENTINEL): $(srcdir)/make-stl-wrappers.py $(srcdir)/$(stl_compiler)-stl-wrapper.template.h $(srcdir)/stl-headers $(GLOBAL_DEPS)
>  	$(PYTHON) $(srcdir)/make-stl-wrappers.py stl_wrappers $(stl_compiler) $(srcdir)/$(stl_compiler)-stl-wrapper.template.h $(srcdir)/stl-headers
> +	$(PYTHON) $(srcdir)/nsinstall.py -t stl_wrappers $(DIST)

Presumably we could move all this logic into the Python script at some point, but that's followup fodder.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20a4b8ad2107

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/20a4b8ad2107