Closed Bug 913005 Opened 6 years ago Closed 6 years ago

Modifications to stl_wrappers rebuild anything that includes stl headers

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Considering the rule to build stl_wrappers depend on GLOBAL_DEPS, on top of the list of headers itself, that makes it happen an awful lot.
Can we at least make these FileAvoidWrite? They don't change much, should make most of the pain go away.
Comment on attachment 800172 [details] [diff] [review]
Avoid overwriting unchanged stl_wrappers

Review of attachment 800172 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/Makefile.in
@@ +112,5 @@
>  STL_WRAPPERS_SENTINEL = $(DIST)/stl_wrappers/sentinel
>  
>  $(STL_WRAPPERS_SENTINEL): $(srcdir)/make-stl-wrappers.py $(srcdir)/$(stl_compiler)-stl-wrapper.template.h $(srcdir)/stl-headers $(GLOBAL_DEPS)
>  	$(PYTHON) $(srcdir)/make-stl-wrappers.py stl_wrappers $(stl_compiler) $(srcdir)/$(stl_compiler)-stl-wrapper.template.h $(srcdir)/stl-headers
> +	$(PYTHON) $(srcdir)/nsinstall.py -t stl_wrappers $(DIST)

Presumably we could move all this logic into the Python script at some point, but that's followup fodder.
Attachment #800172 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/20a4b8ad2107
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.