Modifications to stl_wrappers rebuild anything that includes stl headers

RESOLVED FIXED in mozilla26

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Considering the rule to build stl_wrappers depend on GLOBAL_DEPS, on top of the list of headers itself, that makes it happen an awful lot.
Can we at least make these FileAvoidWrite? They don't change much, should make most of the pain go away.
(Assignee)

Comment 2

4 years ago
Created attachment 800172 [details] [diff] [review]
Avoid overwriting unchanged stl_wrappers
Attachment #800172 - Flags: review?(ted)
Comment on attachment 800172 [details] [diff] [review]
Avoid overwriting unchanged stl_wrappers

Review of attachment 800172 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/Makefile.in
@@ +112,5 @@
>  STL_WRAPPERS_SENTINEL = $(DIST)/stl_wrappers/sentinel
>  
>  $(STL_WRAPPERS_SENTINEL): $(srcdir)/make-stl-wrappers.py $(srcdir)/$(stl_compiler)-stl-wrapper.template.h $(srcdir)/stl-headers $(GLOBAL_DEPS)
>  	$(PYTHON) $(srcdir)/make-stl-wrappers.py stl_wrappers $(stl_compiler) $(srcdir)/$(stl_compiler)-stl-wrapper.template.h $(srcdir)/stl-headers
> +	$(PYTHON) $(srcdir)/nsinstall.py -t stl_wrappers $(DIST)

Presumably we could move all this logic into the Python script at some point, but that's followup fodder.
Attachment #800172 - Flags: review?(ted) → review+

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/20a4b8ad2107
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.