Closed Bug 913015 Opened 7 years ago Closed 7 years ago

[Settings] Buttons are not using 1.5rem margins

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

All
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: epang, Assigned: arnau)

Details

(Whiteboard: visual design, visual-tracking)

Attachments

(3 files)

Attached image button margins.jpg
Hi Arnau,

I've noticed that many of the buttons in settings still have 30 px margins and don't seem to be following the building blocks.

The buttons should have 15px margins with the a left margin of 30px for text.

Can you take a look at why some are still appearing incorrectly?  Would be great if we can have this fixed before Sept 16th so it makes it into 1.2.

Thanks!
Attached image layout.png
Arnau, here's a mock up with all the spacing spec'ed out.  Let me know if anything else is needed.  Thanks!
(In reply to Eric Pang [:epang] from comment #1)
> Created attachment 802207 [details]
> layout.png
> 
> Arnau, here's a mock up with all the spacing spec'ed out.  Let me know if
> anything else is needed.  Thanks!

Hey Arnau, do you think we'll be able to have this ready for 1.2?
Flags: needinfo?(arnau)
Attached file patch in github
Attachment #804322 - Flags: review?(pivanov)
Flags: needinfo?(arnau)
Comment on attachment 804322 [details]
patch in github

I had only one comment on github ... when we fix it we can merge this :)
10x Aranu :)
Attachment #804322 - Flags: review?(pivanov) → review+
Comment on attachment 804322 [details]
patch in github

Looks amazing, makes such a difference!
Attachment #804322 - Flags: feedback?(epang) → feedback+
(In reply to Eric Pang [:epang] from comment #1)
> Created attachment 802207 [details]
> layout.png
> 
> Arnau, here's a mock up with all the spacing spec'ed out.  Let me know if
> anything else is needed.  Thanks!

Fixed!(In reply to Pavel Ivanov [:ivanovpavel] from comment #4)
> Comment on attachment 804322 [details]
> patch in github
> 
> I had only one comment on github ... when we fix it we can merge this :)
> 10x Aranu :)

Fixed!
Merged (523eb19201562957393068709f0deedcf870928f)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
No longer blocks: 927785
You need to log in before you can comment on or make changes to this bug.