913015 - [Settings] Buttons are not using 1.5rem margins

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Eric Pang [:epang] UX]

Attachment: button margins.jpg

Hi Arnau,

I've noticed that many of the buttons in settings still have 30 px margins and don't seem to be following the building blocks.

The buttons should have 15px margins with the a left margin of 30px for text.

Can you take a look at why some are still appearing incorrectly?  Would be great if we can have this fixed before Sept 16th so it makes it into 1.2.

Thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: layout.png

Arnau, here's a mock up with all the spacing spec'ed out.  Let me know if anything else is needed.  Thanks!

Comment 2

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #1)
> Created attachment 802207 [details]
> layout.png
> 
> Arnau, here's a mock up with all the spacing spec'ed out.  Let me know if
> anything else is needed.  Thanks!

Hey Arnau, do you think we'll be able to have this ready for 1.2?

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 804322 [details]
patch in github

I had only one comment on github ... when we fix it we can merge this :)
10x Aranu :)

Comment 5

[Eric Pang [:epang] UX]

Comment on attachment 804322 [details]
patch in github

Looks amazing, makes such a difference!

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

(In reply to Eric Pang [:epang] from comment #1)
> Created attachment 802207 [details]
> layout.png
> 
> Arnau, here's a mock up with all the spacing spec'ed out.  Let me know if
> anything else is needed.  Thanks!

Fixed!(In reply to Pavel Ivanov [:ivanovpavel] from comment #4)
> Comment on attachment 804322 [details]
> patch in github
> 
> I had only one comment on github ... when we fix it we can merge this :)
> 10x Aranu :)

Fixed!

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged (523eb19201562957393068709f0deedcf870928f)