L20n spec grammar.html: change <a name="…"> to <span id="…">, highlight :target identifier.

RESOLVED FIXED

Status

L20n
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mgol, Unassigned)

Tracking

Details

Attachments

(2 attachments)

Created attachment 800189 [details] [diff] [review]
Style patch

There are two HTML/style issues in current grammar.html file:

1) Target is not highlighted. If one clicks on an identifier on a large screen, it's sometimes very hard to locate one on the screen. I added a slight background + white color, now it's obvious where does the internal link points. I also added a slight padding to identifiers so that the color doesn't look strange (as it was when it was touching the text)

2) Using the anchor tag for non-links is non-semantic, there's also no reason to use the name attribute instead of id for internal links. I've changed all <a name="..."> to <span id="...">.
Attachment #800189 - Flags: review?(stas)
Created attachment 800191 [details]
Screenshot of how currently linked identifier looks like after applying the patch.
Comment on attachment 800189 [details] [diff] [review]
Style patch

Review of attachment 800189 [details] [diff] [review]:
-----------------------------------------------------------------

This is great, thanks so much!  I can't believe how much readable the grammar is thanks to this change :)
Attachment #800189 - Flags: review?(stas) → review+
Landed: https://github.com/l20n/spec/commit/877e934d01e42de2b0e8a860600dffa342fd866a and updated http://l20n.github.io/spec/grammar.html

\o/
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.