Closed Bug 91305 Opened 23 years ago Closed 22 years ago

add univerialchardet into unix default extensions list

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: ftang, Assigned: shanjian)

Details

(Keywords: intl, Whiteboard: [adt2])

Attachments

(1 file, 3 obsolete files)

remove configure change from previous patch
1.98 KB, patch
netscape
: review+
jesup
: superreview+
jesup
: approval+
Details | Diff | Splinter Review 
we currently have win makefile for mozilla/extensions/univerialchardet
We need Unix Makefile for it also.
Attached patch proposed patch 1.0 (obsolete) — — Splinter Review 

    
    

    
  
The above patch haven't been tested yet. 
roy, do you have a *nix box to try it out? Since my unix boxes are all offline 
right now, I have to transfer the files back and forth to get it done. 


Status: NEW → ASSIGNED

    
    

    
  
Sorry Shanjian.
I had a machine last week; but I need to reformat it for W98 bug. 
Frank/Brian: do you have one for shanjian?

    
    

    
  
I tried this patch on unix, and it works fine. Now seeking r/sr.

leaf, can you r/sr this one?

    
    

    
  
mark it as M9.4
Target Milestone: --- → mozilla0.9.4

    
    

    
  
r=leaf

    
    

    
  
I already added makefiles for universal chardet (see bug 75924), and the ones I
added should work with MOZ_TRACK_MODULE_DEPS and the static build.  Is there any
reason not to leave those as-is?

(It still needs to be added to the default build, if that's what you want, by
changing one line in configure.in.)

    
    

    
  
I didn't notice that it has been done. Thanks for doing it. I will mark this one 
as a dup. 

*** This bug has been marked as a duplicate of 75924 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE

    
    

    
  
Did you want to turn it on in the default build?  If so, you should use this bug
for it.

    
    

    
  
Reopening since I was under the impression (from another bug, I forget the
number) that this was supposed to be on in default builds.  The way to do that
(if that's what you want to do) is to add universalchardet to the
MOZ_EXTENSIONS_DEFAULT line in configure.in.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

    
    

    
  
Roy, I am not sure what is the decision/discussion about turning universal 
charset detector on for mozilla. If it is default for mozilla, we will need to 
make some changes in commercial build and exclude this module, since we already 
have one in commercial tree. 
Assignee: shanjian → yokoyama
Status: REOPENED → NEW

    
    

    
  
shanjian:  Turning the Universal CharDet ON for the mozilla has been 
completed in Win32 platform.  There is a makefile.win under \extensions
in the commercial tree which overrides the makefile.win in the mozilla
tree.  \\extensions\makefile does not include the universalchardet 
which is a good thing since we want our 3rd party All-chardet to be 
included in the commercial build.


    
    

    
  
shanjian: please make this built by default.
Assignee: yokoyama → shanjian

    
    

    
  
posting the patch:
Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.901
diff -u -r1.901 configure.in
--- configure.in        2001/08/28 08:39:23     1.901
+++ configure.in        2001/08/29 23:22:50
@@ -3404,7 +3404,7 @@
 dnl Need cookie and wallet to build mozilla, this should
 dnl not be the case, 18352 has been filed.
 dnl http://bugzilla.mozilla.org/show_bug.cgi?id=18352
-MOZ_EXTENSIONS_DEFAULT="cookie wallet content-packs xml-rpc xmlextras help tran
sformiix"
+MOZ_EXTENSIONS_DEFAULT="cookie wallet content-packs xml-rpc xmlextras help tran
sformiix universalchardet"
 MOZ_EXTENSIONS_ALL="$MOZ_EXTENSIONS_DEFAULT irc xmlterm inspector access-builti
n venkman"
Status: NEW → ASSIGNED

    
    

    
  
dbaron, could you r/sr this one? thx!

    
    

    
  
joe, could you give sr? thx.

    
    

    
  
sr=hewitt

    
    

    
  
update the summary.
Summary: need unix Makefile for mozilla/extensions/univerialchardet → add univerialchardet into unix default extensions list

    
    

    
  
a=asa on behalf of drivers

    
    

    
  
This is for mozilla release only. move to m0.9.5
Target Milestone: mozilla0.9.4 → mozilla0.9.5

    
    

    
  
For commercial build, this is not wanted. I need to file figure out how to do that before checkin this one. 
Target Milestone: mozilla0.9.5 → mozilla0.9.6

    
    

    
  
move to m98. m96 is out. 
Target Milestone: mozilla0.9.6 → mozilla0.9.8

    
  
QA Contact: andreasb → ylong

    
    

    
  
Roy Yokoyma says in comment #12 says that in commercial build in Windows both
this autodetector and the commercial one are included.

I don't see any reason why it can't be the same under Unix/Linux.

I was very surprised to see there was no auto-detector in Linux.

    
    

    
  
One note: we build both this autodetector and the commercial one; however
we remove this autodetector at commercial *package* time 
so that there is only one autodetector.

Hope this makes sense for you. ;)


    
    

    
  
If "auto-detect/all" in commercial and "auto-detect/universal" are completely 
independant, I don't get why they behave exactly the same with regard to bug 
115114 .

    
    

    
  
Simply speaking, autodetect/all is a superset of autodetect/universal. It 
includes some 3rd party component which prevent us from putting into mozilla 
tree. When universal detector can cover enough languages, we will get rid of 
autodetect/all. 

    
  
Target Milestone: mozilla0.9.8 → mozilla1.0.1

    
    

    
  

      
      
      
      

        Attached patch
          
          
        new patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #42717 -
        Attachment is obsolete: true

    
    

    
  


  

        Attachment #78415 -
        Attachment is obsolete: true

    
    

    
  
This should be a very low risk bug. Universal charset detector has been tested
on win/mac/unix platform. The reason I did not make it default is because we
still have detector all in commercial build. Now we decide to remove detector
all, and universal must be made to be default at the same time. 

nominate as nsbeta1

    
    

    
  
really add the nsbeta1 keyword
Keywords: intl, 
          
            nsbeta1

    
    

    
  
There is a script that automatically updates and checks in configure when 
configure.in is changed.


    
    

    
  


  

        Attachment #78432 -
        Attachment is obsolete: true

    
    

    
  
cls, could you r= my patch?

    
    

    
  
Comment on attachment 78565 [details] [diff] [review]
remove configure change from previous patch

You shouldn't need to add libuniversalchardet.so to the packages-unix-static
file as the component should be linked into the binary. Fix that nit && r=cls

        Attachment #78565 -
        Flags: review+

    
    

    
  
we need to fix this first so we can use the universial detector in the
communical tree 
Whiteboard: [adt2]

    
    

    
  
nsbeta1+
Keywords: nsbeta1 → nsbeta1+

    
    

    
  
Comment on attachment 78565 [details] [diff] [review]
remove configure change from previous patch

a=rjesup@wgate.com for branch.	Please check in on trunk as well.  Moving sr=
forward since there's been no effective change to the patch.

        Attachment #78565 -
        Flags: superreview+

        Attachment #78565 -
        Flags: approval+

    
    

    
  
fix checked in to trunk. Wait for adt approval for branch.

    
    

    
  
please adt1.0.0+ this bug. 
Keywords: adt1.0.0

    
    

    
  
Is this a regression?

Removing adt1.0.0. Pls have iQA verify that this fix causes no issue on the
trunk, before renominating.
Keywords: adt1.0.0

    
    

    
  
Both auto-detect All and Universal are showing up on 04-11 trunk build / linux
RH7.2.

Seems both of them are work fine with my very brief check. 



    
    

    
  
adt1.0.0 again
>Removing adt1.0.0. Pls have iQA verify that this fix causes no issue 
>on the trunk, before renominating.
ylong test that on Linux as her comment below:

>Both auto-detect All and Universal are showing up on 04-11 
>trunk build / linux RH7.2. Seems both of them are work fine with my
>very brief check. 


Keywords: adt1.0.0

    
    

    
  
adt1.0.0+ by adt. somehow the comment paul add didn't put into this bug report. 
Keywords: adt1.0.0 → adt1.0.0+

    
    

    
  
fix checked into 1.0 branch. 
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.0.1 → mozilla1.0

    
    

    
  
I only see auto-detect All in 04-15 branch build / linux RH7.2, but I saw both
auto-Detect All and Universal in 04-15 Mac branch build /Mac 10.1.3.


    
    

    
  
On 04-22 branch build, I still only see auto-detect All but no auto-detect
Universal on both Linux and windows.  But on Mac, both auto-detect All and
Universal appear.

Did we really checked into branch build?

    
    

    
  
Yuying, after bugscape 13633 checks into branch, you will see universal detector
in commercial build. 
As long as you can see universal detector in linux mozilla build, you can mark
this one verified. 

    
    

    
  
I understand we'll replace auto-detect All by Universal.  My point was: I can
not see auto-detect Universal in branch build on windows and linux.

Or it not visible at current branch build untill bugscape 13633 checked into branch?

    
    

    
  
On 04-23 RC1 linux branch build / RH7.2, neither auto-detect All nor Universal
appear.  Like I said a few days ago, we probably missed something in linux
branch build.  But I'm not sure if cause by this bug or bugscape 13633.

Re-open.
Status: RESOLVED → REOPENED
OS: Windows NT → Linux
Resolution: FIXED → ---

    
    

    
  
Yuying, please verify that today's daily builds have universal only in both
mozilla build and commercail build. Please also let me know RC1 build your
mentioned is mozilla or commercial. I may need to talk with a build engineer to
figure it out. 
Status: REOPENED → ASSIGNED

    
    

    
  
I have checked 04-23 build, looks all others - (mozilla linux RC1 installer is
nto working) work fine - only auto-detect Universal, except linux RC1 branch build.

    
    

    
  
Mozilla 04-22 RC1 branch build has same problem as Netscape 04-23 branch build
on linux - neither auto-detect All nor Universal is existing.

The problem only in linux branch build, Windows and Mac builds only has
Universal which is correct behavior.

    
    

    
  
This might be because file "configure" is not automated updated after I checked
in the patch to branch. I notified build engineer about the problem. It should
be rather easy to be taken care of.

    
    

    
  
If this is on the 1.0 branch, pls add the fixed1.0.0 keyword, and have ylong
verify asap. thanks!

    
    

    
  
This bug won't be verified if they (build engineers) do not update configure
from configure.in. I sent leaf email, left him message, but the configure file
still looks untouched. Our people is too busy. 

    
    

    
  
You can run autoconf yourself and check in the resulting configure (preferably
from an RH 6.2 machine, I think, since the one generated by a 7.x machine might
be slightly different).

    
    

    
  
I don't have RH6.2. But I am very confident that I can modify "configure" file
manually, since there is only one string change. bstell suggest that this is
something should happen automatically, or at least by somebody with certain
priviledge. If I am allowed to do it, I can do it. 

    
    

    
  
Just run "autoconf" and see if any of the diffs to configure are something you
wouldn't have expected.

    
    

    
  
Shanjian: Is this what you are expecting to be in the configure file?
(http://lxr.mozilla.org/seamonkey/source/configure#10893):

  MOZ_EXTENSIONS_DEFAULT=" cookie wallet content-packs xml-rpc xmlextras 
        help pref transformiix venkman inspector irc universalchardet"

Bonsai shows that your change to configure.in 

  1.1032 shanjian%netscape.com  Apr 10 15:47 #91305 add univerialchardet into 
                                             unix default extensions list
                                             r=cls sr=hewitt a=rjesup@wgate.com

went from configure.in to configure automatically some 9 minutes after your 
configure.in checkin: 

 http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/configure

   1.950 leaf%mozilla.org  Apr 10 15:56 Automated update

    
    

    
  
Aki did a great job helping me get the FreeType code working on the build
systems, bug 126713.

    
    

    
  
brian, what you saw is in trunk. Configure file is not updated after I checked
in this for branch. 

I did it myself just now. 
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED

    
    

    
  
Verified fixed on 04-29 branch build - Universal(not All) appears and works.

Brian, please do update the free type on branch build if needed.
Status: RESOLVED → VERIFIED
Keywords: adt1.0.0+ → verified1.0.0

    
    

    
  
> Brian, please do update the free type on branch build if needed.

Is there some issue with FreeType on the branch? 

This is the first I have heard anything like that suggested.

    
    

    
  
I said that was because the comment #62 although I'm not sure if it necessary. 
Please forget it if there is no such need on branch build.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: