Use an accessor for the "main" imported patch to make it more clear that there's only one

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
Currently, there's an imported_patches array used to transmit the main patch name from the bzhandler.py module to __init__.py. But it'll always hold exactly one element, so it's deceptive when reading the code.
Assignee

Comment 1

6 years ago
I'm not sure I really like the global variable accessor either, but I imagine jdm can tell me if there's a better way.
Attachment #800240 - Flags: review?(josh)
Comment on attachment 800240 [details] [diff] [review]
Use an accessor for the "main" imported patch to make it more clear that there's only one.

Review of attachment 800240 [details] [diff] [review]:
-----------------------------------------------------------------

I can't think of a better way.
Attachment #800240 - Flags: review?(josh) → review+
Assignee

Updated

6 years ago
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Other Applications → Developer Services
You need to log in before you can comment on or make changes to this bug.