913083 - Use an accessor for the "main" imported patch to make it more clear that there's only one

Status: RESOLVED FIXED

(Developer Services :: Mercurial: qimportbz, defect)

Description

[Steve Fink [:sfink] [:s:]]

Currently, there's an imported_patches array used to transmit the main patch name from the bzhandler.py module to __init__.py. But it'll always hold exactly one element, so it's deceptive when reading the code.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Use an accessor for the "main" imported patch to make it more clear that there's only one.

I'm not sure I really like the global variable accessor either, but I imagine jdm can tell me if there's a better way.

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 800240 [details] [diff] [review]
Use an accessor for the "main" imported patch to make it more clear that there's only one.

Review of attachment 800240 [details] [diff] [review]:
-----------------------------------------------------------------

I can't think of a better way.

Comment 3

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/users/robarnold_cmu.edu/qimportbz/rev/9c5006e8d531