913123 - Update featured apps code to take into account pricing data

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[[e-mail]]

In the new world order of regions for paid apps we are going to take into account both addon excluded regions as well as the price data for a given app.

To this end we need to ensure that featured apps take into account both of those criteria so that if an app is not relevant to the current region due to either price or excluded region records it doesn't show up.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

What about apps listed in a curated collection? Or in an operator shelf (operator's list of promoted apps)?

Comment 2

[[e-mail]]

:cvan - yep this would need to work the same there too. I was planning to ask you about collections etc to find out where these changes are needed.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

For whoever implements this, direct any questions to Stuart, Andy, or me.

Comment 4

[[e-mail]]

See bug 909532 for the logic that will be used for updating the app search index - this change should follow the same idea.

Comment 5

[[e-mail]]

:mat I've made this depend on the bug that will provide the excluded regions taking into account the payment data which will probably be useful for this bug.

Let me know if you have any questions.

Comment 6

[Mathieu Pillard [:mat]]

I made a pull request to do this, https://github.com/mozilla/zamboni/pull/1153 but we are going to try to go the ElasticSearch route in bug 927420 so I closed it, just mentioning it here for future reference just in case.

Comment 7

[Mathieu Pillard [:mat]]

This should be fixed by bug 927420.

STR:
- Enable the waffle flag 'collections-use-es-for-apps' on -dev
- Submit a non-free app. When you are done, pick a region where payments are not available in.
- Push the app to public in the reviewer tools
- Using the curation tool, add that app to the featured apps collection that appear for the homepage of the region you picked earlier. Also add a normal app just to make sure you will be able to see the collection.
- Visit the homepage for that region. 
- The paying app should not appear in the featured apps collection.

Note: for the region, 'Peru' currently fits on -dev: it doesn't have payments and it already has a featured apps collection active.