Closed Bug 913254 Opened 11 years ago Closed 3 years ago

Intermittent testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect, P3)

ARM
Android
defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: KWierso, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled][leave open])

+++ This bug was initially created as a clone of Bug #907769 +++

https://tbpl.mozilla.org/php/getParsedLog.php?id=27453998&tree=Fx-Team&full=1
Android Tegra 250 fx-team opt test robocop-2
slave: tegra-227


26 INFO TEST-UNEXPECTED-FAIL | testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed
Exception caught during test!
junit.framework.AssertionFailedError: 26 INFO TEST-UNEXPECTED-FAIL | testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed
	at junit.framework.Assert.fail(Assert.java:47)
	at org.mozilla.fennec.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:111)
	at org.mozilla.fennec.FennecMochitestAssert.ok(FennecMochitestAssert.java:140)
	at org.mozilla.fennec.tests.AboutHomeTest.waitForAboutHomeTab(AboutHomeTest.java:341)
	at org.mozilla.fennec.tests.AboutHomeTest.openAboutHomeTab(AboutHomeTest.java:380)
	at org.mozilla.fennec.tests.testShareLink.testShareLink(testShareLink.java:90)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:521)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186)
	at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:161)
	at junit.framework.TestCase.runBare(TestCase.java:127)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447)
27 INFO TEST-UNEXPECTED-FAIL | testShareLink | Exception caught - junit.framework.AssertionFailedError: 26 INFO TEST-UNEXPECTED-FAIL | testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed

09-05 15:13:41.267 I/Robocop ( 2701): 26 INFO TEST-UNEXPECTED-FAIL | testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed
09-05 15:13:41.359 I/Robocop ( 2701): Exception caught during test!
09-05 15:13:41.359 I/Robocop ( 2701): junit.framework.AssertionFailedError: 26 INFO TEST-UNEXPECTED-FAIL | testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed
09-05 15:13:41.359 I/Robocop ( 2701): 	at junit.framework.Assert.fail(Assert.java:47)
09-05 15:13:41.359 I/Robocop ( 2701): 	at org.mozilla.fennec.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:111)
09-05 15:13:41.359 I/Robocop ( 2701): 	at org.mozilla.fennec.FennecMochitestAssert.ok(FennecMochitestAssert.java:140)
09-05 15:13:41.359 I/Robocop ( 2701): 	at org.mozilla.fennec.tests.AboutHomeTest.waitForAboutHomeTab(AboutHomeTest.java:341)
09-05 15:13:41.359 I/Robocop ( 2701): 	at org.mozilla.fennec.tests.AboutHomeTest.openAboutHomeTab(AboutHomeTest.java:380)
09-05 15:13:41.359 I/Robocop ( 2701): 	at org.mozilla.fennec.tests.testShareLink.testShareLink(testShareLink.java:90)
09-05 15:13:41.359 I/Robocop ( 2701): 	at java.lang.reflect.Method.invokeNative(Native Method)
09-05 15:13:41.359 I/Robocop ( 2701): 	at java.lang.reflect.Method.invoke(Method.java:521)
09-05 15:13:41.359 I/Robocop ( 2701): 	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204)
09-05 15:13:41.359 I/Robocop ( 2701): 	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194)
09-05 15:13:41.359 I/Robocop ( 2701): 	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186)
09-05 15:13:41.359 I/Robocop ( 2701): 	at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:161)
09-05 15:13:41.359 I/Robocop ( 2701): 	at junit.framework.TestCase.runBare(TestCase.java:127)
09-05 15:13:41.359 I/Robocop ( 2701): 	at junit.framework.TestResult$1.protect(TestResult.java:106)
09-05 15:13:41.359 I/Robocop ( 2701): 	at junit.framework.TestResult.runProtected(TestResult.java:124)
09-05 15:13:41.359 I/Robocop ( 2701): 	at junit.framework.TestResult.run(TestResult.java:109)
09-05 15:13:41.359 I/Robocop ( 2701): 	at junit.framework.TestCase.run(TestCase.java:118)
09-05 15:13:41.359 I/Robocop ( 2701): 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
09-05 15:13:41.359 I/Robocop ( 2701): 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
09-05 15:13:41.359 I/Robocop ( 2701): 	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520)
09-05 15:13:41.359 I/Robocop ( 2701): 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447)
09-05 15:13:41.359 I/Robocop ( 2701): 27 INFO TEST-UNEXPECTED-FAIL | testShareLink | Exception caught - junit.framework.AssertionFailedError: 26 INFO TEST-UNEXPECTED-FAIL | testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed
09-05 15:13:41.359 I/Robocop ( 2701): 28 INFO TEST-END | testShareLink | finished in 66903ms
09-05 15:13:41.359 I/Robocop ( 2701): 29 INFO TEST-START | Shutdown
09-05 15:13:41.359 I/Robocop ( 2701): 30 INFO Passed: 24
09-05 15:13:41.359 I/Robocop ( 2701): 31 INFO Failed: 2
09-05 15:13:41.359 I/Robocop ( 2701): 32 INFO Todo: 0
09-05 15:13:41.359 I/Robocop ( 2701): 33 INFO SimpleTest FINISHED
09-05 15:13:41.469 D/GeckoHealthRec( 2701): Recording session end: P
09-05 15:13:41.499 V/GeckoHealthRec( 2701): Recorded session entry for env 1, current is 1
09-05 15:13:41.499 D/GeckoSessInfo( 2701): Recording session done: 1378394012009
09-05 15:13:41.529 W/GeckoGLController( 2701): GLController::surfaceDestroyed() with mCompositorCreated=true
09-05 15:13:41.529 W/GeckoGLController( 2701): done GLController::surfaceDestroyed()
09-05 15:13:41.569 W/GeckoEventDispatcher( 2701): unregisterEventListener: event 'TextSelection:Data' has no listeners
09-05 15:13:41.569 I/GeckoHealthRec( 2701): Closing Health Report client.
09-05 15:13:41.569 W/ActivityManager( 1020): Duplicate finish request for HistoryRecord{4869e540 android/com.android.internal.app.ChooserActivity}
09-05 15:13:42.478 W/WindowManager( 1020): Permission denied: injecting key event from pid 2701 uid 10033 to window Window{4857d0e8 com.mozilla.SUTAgentAndroid/com.mozilla.SUTAgentAndroid.SUTAgentAndroid paused=false} owned by uid 10031
09-05 15:13:42.577 I/TestRunner( 2701): failed: testShareLink(org.mozilla.fennec.tests.testShareLink)
09-05 15:13:42.577 I/TestRunner( 2701): ----- begin exception -----
09-05 15:13:42.577 I/TestRunner( 2701): 
09-05 15:13:42.577 I/TestRunner( 2701): junit.framework.AssertionFailedError: 27 INFO TEST-UNEXPECTED-FAIL | testShareLink | Exception caught - junit.framework.AssertionFailedError: 26 INFO TEST-UNEXPECTED-FAIL | testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed
09-05 15:13:42.577 I/TestRunner( 2701): 	at junit.framework.Assert.fail(Assert.java:47)
09-05 15:13:42.577 I/TestRunner( 2701): 	at org.mozilla.fennec.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:111)
09-05 15:13:42.577 I/TestRunner( 2701): 	at org.mozilla.fennec.FennecMochitestAssert.ok(FennecMochitestAssert.java:140)
09-05 15:13:42.577 I/TestRunner( 2701): 	at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:168)
09-05 15:13:42.577 I/TestRunner( 2701): 	at junit.framework.TestCase.runBare(TestCase.java:127)
09-05 15:13:42.577 I/TestRunner( 2701): 	at junit.framework.TestResult$1.protect(TestResult.java:106)
09-05 15:13:42.577 I/TestRunner( 2701): 	at junit.framework.TestResult.runProtected(TestResult.java:124)
09-05 15:13:42.577 I/TestRunner( 2701): 	at junit.framework.TestResult.run(TestResult.java:109)
09-05 15:13:42.577 I/TestRunner( 2701): 	at junit.framework.TestCase.run(TestCase.java:118)
09-05 15:13:42.577 I/TestRunner( 2701): 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
09-05 15:13:42.577 I/TestRunner( 2701): 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
09-05 15:13:42.577 I/TestRunner( 2701): 	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520)
09-05 15:13:42.577 I/TestRunner( 2701): 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447)
09-05 15:13:42.577 I/TestRunner( 2701): ----- end exception -----
09-05 15:13:42.577 I/TestRunner( 2701): finished: testShareLink(org.mozilla.fennec.tests.testShareLink)
09-05 15:13:42.587 I/Process ( 1020): Sending signal. PID: 2771 SIG: 9
09-05 15:13:42.587 D/AndroidRuntime( 2693): Shutting down VM
09-05 15:13:42.587 I/Process ( 1020): Sending signal. PID: 2701 SIG: 9
09-05 15:13:42.587 D/jdwp    ( 2693): adbd disconnected
09-05 15:13:42.587 I/ActivityManager( 1020): Force stopping package org.mozilla.fennec uid=10033
https://tbpl.mozilla.org/php/getParsedLog.php?id=29990349&tree=Fx-Team
Summary: Intermittent testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed → Intermittent testShareLink, testReaderMode | Checking that the correct tab is displayed - The HISTORY tab is displayed
Geoff, don't suppose you could find someone to own this? :-)
Flags: needinfo?(gbrown)
I think there is a good chance that bug 933428 will address this for testShareLink. 

I'll take it, at least until we can verify that.
Assignee: nobody → gbrown
Flags: needinfo?(gbrown)
(In reply to Geoff Brown [:gbrown] from comment #47)
> I think there is a good chance that bug 933428 will address this for
> testShareLink. 
> 
> I'll take it, at least until we can verify that.

Thank you :-)
It seems testShareLink is fine now.

I am investigating testReaderMode, but no success yet.

https://tbpl.mozilla.org/?tree=Try&rev=ca85e97ee806
https://tbpl.mozilla.org/?tree=Try&rev=834a18768ad7
testReaderMode disabled on inbound.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ef4a45698ea

testReaderMode and testShareLink disabled on Aurora.
https://hg.mozilla.org/releases/mozilla-aurora/rev/773937451ebe

testShareLink disabled on Beta.
https://hg.mozilla.org/releases/mozilla-beta/rev/75eca4e44eec
Whiteboard: [test disabled][leave open]
I am not finding time to sort this out -- unassigning myself.

I looked into the failures but did not find a definitive cause. 

I have several concerns:
 - https://hg.mozilla.org/mozilla-central/annotate/7225e584d6c7/mobile/android/base/tests/testReaderMode.java#l109 waits for the text "Robocop Text Page" as evidence that the previous action has switched to the Reader List and the Robocop Text Page has been added to the Reader List, but "Robocop Text Page" is already present on the screen before that operation (in the title/url bar), reducing the waitForText to an intermittent no-op;
 - the test waits for the reader toolbar to be displayed mostly by waiting for the page to load; this seems less than definitive;
 - there is no way to verify that the reader toolbar is displayed;
 - the test clicks on the edges (+/- 10 pixels) of the reader toolbar buttons, rather than in the button centers.

In general, it seems to me that interaction with the reader toolbar is problematic -- it may not be possible to test this feature reliably with Robocop.
Assignee: gbrown → nobody
testReaderMode has been disabled for so long that I decided to just remove it, and replace it with a simpler testReaderView test.

At this point I feel like testShareLink is probably also way out of date, so maybe we should just remove that as well and close this bug.
Depends on: 1158885
Summary: Intermittent testShareLink, testReaderMode | Checking that the correct tab is displayed - The HISTORY tab is displayed → Intermittent testShareLink | Checking that the correct tab is displayed - The HISTORY tab is displayed
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.