913289 - [Buri][Call]Making a call,cannot show the number in screen

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[sync-1]

Firefox os  v1.1
  Mozilla build ID:20130902041201
 
 DEFECT DESCRIPTION:
 Making a call from a contact number with prefix,cannot show the number in screen
  REPRODUCING PROCEDURES:
 1.Add a contact number [phone] and the name "Paco"
 2.Open the dialer
 3.Make a call to the number 0033683498036--KO in screen shows no number
  EXPECTED BEHAVIOUR:
 In screen can shows the call number
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 middle
  REPRODUCING RATE:
 5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: 参考图

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: PR518464.log

Comment 5

[Mingming ZHAO]

Hi, the reason is, this MCC of China is not in the list "_mccWith00Prefix: ['208', '214', '234', '235', '724']"( https://github.com/mozilla-b2g/gaia/blob/master/shared/js/simple_phone_matcher.js#L105).

Comment 6

[Preeti Raghunath(:Preeti)]

David,

Please have someone review this bug. leo+ as it looks bad.

Comment 7

[:gerard-majax]

(In reply to Mingming ZHAO from comment #5)
> Hi, the reason is, this MCC of China is not in the list "_mccWith00Prefix:
> ['208', '214', '234', '235', '724']"(
> https://github.com/mozilla-b2g/gaia/blob/master/shared/js/
> simple_phone_matcher.js#L105).

I'm having the same with a Telenor SIM card.

Comment 8

[:gerard-majax]

(In reply to Mingming ZHAO from comment #5)
> Hi, the reason is, this MCC of China is not in the list "_mccWith00Prefix:
> ['208', '214', '234', '235', '724']"(
> https://github.com/mozilla-b2g/gaia/blob/master/shared/js/
> simple_phone_matcher.js#L105).

Do you have anything that supports this theory ? I'm reproducing the issue with a french SIM card and french numbers, yet french MCC is in this list.

Comment 9

[:gerard-majax]

As far as I can say from the indexedDB, there is no '00' contact phone number variant generated.

Comment 10

[:gerard-majax]

Wilfred, do we want to support this?

Comment 11

[Wilfred Mathanaraj [:WDM]]

We saw this same bug with a HTC android device but I would like this fixed. 

If this warrants a leo fix I am not sure - I would suggest to fix in v1.2.

Comment 12

[Mingming ZHAO]

Because of this https://github.com/mozilla-b2g/gaia/blob/v1-train/shared/js/simple_phone_matcher.js#L57
and https://github.com/mozilla-b2g/gaia/blob/v1-train/shared/js/simple_phone_matcher.js#L58

if the "bestMatchIndex: bestMatchIndex" and "localIndex: bestLocalIndex" are null.

the contact will error. https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/communications/dialer/js/contacts.js#L161

Comment 13

[Preeti Raghunath(:Preeti)]

moved to koi+

Comment 14

[Etienne Segonzac (:etienne)]

Not matching is one thing, but here there is _nothing_ displayed (no number, no contact name).
This should never happen and is the real issue here imho.

I'm unable to reproduce this issue on v1.2.

Comment 15

[Chris Kreinbring [:CKreinbring]]

I am also unable to repro on Buri 1.2 mozilla RIL.  After dialing the number and tapping the Call button, I can see the number shown in the blue bar.  I am using an AT&T SIM for this test.

Build ID: 20130927004015
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/7eebf2d65429
Gaia: 1e9470b9b6df630eddf1c4c8b25b3170ee786b0e
Platform Version: 26.0a2

Comment 16

[Etienne Segonzac (:etienne)]

Please reopen if you can reproduce this on a 1.2 build.