913301 - escodegen cannot handle some syntax (ArrowExpression, ForOfStatement, SpreadExpression, etc)

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[Liu Ping]

escodegen cannot handle some syntax (ArrowExpression, ForOfStatement, SpreadExpression, etc)

In Scratchpad of current Nightly, when "Pretty Print", any of the following lines will throw

  foo = (x) => x+1;
  for (x of [1,2,3]) console.log(x);
  y = [0, ...[1,2,3]];

Comment 1

[Liu Ping]

escodegen issue "Following esprima harmony branch" https://github.com/Constellation/escodegen/issues/12 has stalled for a year.

Maybe it's better to reactive bug 590755, and finish the AST Decompiler.

Comment 2

[Brandon Benvie [:benvie]]

Related discussion about the differences between Parser API and Esprima's harmony AST: https://groups.google.com/d/msg/mozilla.dev.tech.js-engine.internals/viTrirW_Kjc/BnymHfNDPzEJ.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I think it is best to play nice-open-source-citizen and send patches to escodegen. The whole point of integrating escodegen was to avoid NIH and re-inventing the wheel. Better to make escodegen better for everyone than to fork or do our own thing.

Comment 4

[Yusuke Suzuki]

We escodegen developers welcome contributions!
And we'd like to cooperate with SpiderMonkey & Firefox to make Parser API & js-tools more powerful :)

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

escodegen was removed in bug 930141

Comment 6

[Liu Ping]

acorn still cannot handle these listed syntax.

filed Bug 938203