91331 - Language packs in Mac, Linux 0.9.2 builds not crossplatform

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[danielmc]

The Language Packs in the Mac and Linux Mozilla and Commercial builds are 
different from the Windows language packs.

These packs are supposed to be crossplatform. The Windows language packs do 
appear to be properly crossplatform however the Mac and Linux builds are 
missing several files. 

Linux is missing en-mac.jar and a few files in en-US.jar (e.g.net2phone)
Mac is missing en-unix.jar, en-win.jar and a few files in en-US.jar

Although this does not break any functionality in the native builds we should be 
consistent with our cross platform files

Comment 1

[Mike Kaply [:mkaply]]

Can you be more specific by what you mean by language pack?

Are you saying that all platforms should ship all platform languages?

So unix should ship en-mac, en-unix, en-win?

Or is it just that the .xpi file is missing some variations of 
platforms.

We are going to be creating en-os2.jar and I am trying to figure out 
what the right thing is.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Patch to build en-mac.jar and full en-win.jar on unix

Comment 3

[Mike Kaply [:mkaply]]

OK, I understand now. The issue is that a language can only be 
packaged on Windows right now because the other plats are missing the 
additional jar files.

I've attached a diff that builds all the jars properly on Unix.

Looking for a review/superreview

I don't know how to do this for Mac.

For OS/2, I've decided we will just use en-win.jar, and I'm using bug 
91650 for that.

Comment 4

[cls]

r=cls

Comment 5

[Mike Kaply [:mkaply]]

I've checked in the fix for Unix platforms.

Need a Mac guru to do the Mac piece

Comment 6

[tao]

I got the Mac fix in http://bugzilla.mozilla.org/show_bug.cgi?id=71517. Anyone 
care to review?

Comment 7

[Jon Granrose]

since it looks like the unix patch is checked in and the mac issue is being
handled in another bug I'm going to resolve this as fixed.  can tao or the
reporter verify this?