913324 - [Buri] Marketplace favicon launches in an enlarged state

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Marcia Knous [:marcia]]

Attachment: 2013-09-05-19-42-59.png

Seen while running on Buri Device:

Gaia   b77dc7d399c14ac2bafe5c89566b292bc6772d32
SourceStamp df8f342e9a6b
BuildID 20130905185329
Version 26.0a1

STR:
1. Launch the marketplace
2. Observe the attached screenshot.

This seems to happen more when you are using a data connection, but have seen it on wifi connection as well.

Comment 1

[Matt Basta [:basta]]

Looks like the splash.css file is failing to load (notice the tiny X in the upper left).

When you get into this state, does it ever load the Marketplace? Or does it just hang like this?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Marcia, have you seen this in the wild?

I recently added large icons to the manifest: 128, 256, and 512. While these larger icons can be used by desktop clients, I will remove them as these sizes are causing our package size to be significantly larger.

From https://marketplace.firefox.com/packaged.webapp:

    {
        "icons": {
            "120": "/120.png", 
            "128": "/128.png", 
            "256": "/256.png", 
            "512": "/512.png", 
            "60": "/60.png", 
            "90": "/90.png"
        },
        ...
    }

I am worried that we're not the only one experiencing this. Likely, not many others are providing such large icons in their manifests.

Comment 3

[Jason Smith [:jsmith]]

This doesn't look like a marketplace issue - this looks like a bug with the launch screen in Gaia.

Comment 4

[Marcia Knous [:marcia]]

(In reply to Matt Basta [:basta] from comment #1)
> Looks like the splash.css file is failing to load (notice the tiny X in the
> upper left).
> 
> When you get into this state, does it ever load the Marketplace? Or does it
> just hang like this?

It starts this way, then eventually the marketplace does load. Lately on Buri I see it every time marketplace launches.

Comment 5

[Marcia Knous [:marcia]]

I can add a video if that is helpful.

Comment 6

[Lucas Aliaga]

Marketplace splash screen launches normal on 9/04.

- Doesn't Repro - 
Environmental Variables
Build ID: 20130904040205
Gecko: http://hg.mozilla.org/mozilla-central/rev/7ff96bd19c1c
Gaia: b6c5bf1d24230bfed4a8f680e625fa2175001f82
Platform Version: 26.0a1

Marketplace splash screen launches enlarged on 9/05.

- Repro'd -
Environmental Variables
Build ID: 20130905040201
Gecko: http://hg.mozilla.org/mozilla-central/rev/77ed46bf4c1a
Gaia: ec885264d885d877d68980c0227058231f18ad09
Platform Version: 26.0a1

Comment 7

[Preeti Raghunath(:Preeti)]

Gregor,

Is marketplace needed in 1.2?

Comment 8

[Jason Smith [:jsmith]]

(In reply to Preeti Raghunath(:Preeti) from comment #7)
> Gregor,
> 
> Is marketplace needed in 1.2?

Marketplace is core app to the system, so yes.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

I don't see any icon when I try to launch marketplace app. All black and turn into white + loading screen in marketplace.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Alive Kuo [:alive] from comment #9)
> I don't see any icon when I try to launch marketplace app. All black and
> turn into white + loading screen in marketplace.

What device are you testing this on?

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Jason Smith [:jsmith] from comment #10)
> (In reply to Alive Kuo [:alive] from comment #9)
> > I don't see any icon when I try to launch marketplace app. All black and
> > turn into white + loading screen in marketplace.
> 
> What device are you testing this on?

unagi + master + mc.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Alive Kuo [:alive] from comment #11)
> (In reply to Jason Smith [:jsmith] from comment #10)
> > (In reply to Alive Kuo [:alive] from comment #9)
> > > I don't see any icon when I try to launch marketplace app. All black and
> > > turn into white + loading screen in marketplace.
> > 
> > What device are you testing this on?
> 
> unagi + master + mc.

You'll probably need to test on Buri then - I saw this during daily testing on Buri.

Comment 13

[:gerard-majax]

I'm reproducing this also on my Nexus S build that goes back to v1.2 as of early August. As far as I can say, this was not present at first, I'm wondering if it's not due to an update of the Marketplace app.

Comment 14

[:gerard-majax]

Might it be related to bug 901134 ?

Comment 15

[:gerard-majax]

See https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L1148 and https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/cards_view.js#L69, I think we have the explanation :)

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Uh...I propose to change background size to fix this but we don't have a spec yet.
See https://bugzilla.mozilla.org/show_bug.cgi?id=904332

I could try to use a fixed size at first though.

Comment 17

[:gerard-majax]

(In reply to Alive Kuo [:alive] from comment #16)
> Uh...I propose to change background size to fix this but we don't have a
> spec yet.
> See https://bugzilla.mozilla.org/show_bug.cgi?id=904332
> 
> I could try to use a fixed size at first though.

Having hacked the window manager code, I confirm that size matters. In your linked bug, however, I see that: we have no spec, and worst, spec has been nominated v1.3. While the present bug is koi+.

Comment 18

[:gerard-majax]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12847

Pointer to Github pull-request

Comment 19

[:gerard-majax]

Comment on attachment 817036 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12847

Please find attached a link to the github pull request https://github.com/mozilla-b2g/gaia/pull/12847

The proposed fix is simply to select the biggest icon that can fit on the screen. While we have no spec for bug 904332, this is simple and gives quite nice results as far as I could test.

Comment 20

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 817036 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12847

r+ but please cache clientWidth inside a variable.

Comment 21

[:gerard-majax]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #20)
> Comment on attachment 817036 [details]
> Pointer to Github pull request:
> https://github.com/mozilla-b2g/gaia/pull/12847
> 
> r+ but please cache clientWidth inside a variable.

Just updated the pull request, that should be okay now.

Comment 22

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/3f2acba61d72951efcc9dc435fc578fb818ca11b

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 3f2acba61d72951efcc9dc435fc578fb818ca11b to:
v1.2: afdc4b12ba4c305d172f35e7a1f2a74f0103a0d9

Comment 24

[Jason Smith [:jsmith]]

Verified fixed on a 10/23 build.