Glass is broken under win OMTC basic

RESOLVED FIXED in mozilla26

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla26
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 800581 [details] [diff] [review]
Working proof of concept

OMTC Basic is missing some code from nsWindowGfx. Particularly for Glass clearing the DC is important.
http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindowGfx.cpp#397

I have a POC patch that fixes the issue but it clears more then we need. I need to find the right times to clear before landing this.
(Assignee)

Comment 1

5 years ago
Created attachment 800788 [details] [diff] [review]
Good patch
Assignee: nobody → bgirard
Attachment #800581 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #800788 - Flags: review?(jmuizelaar)
Comment on attachment 800788 [details] [diff] [review]
Good patch

Review of attachment 800788 [details] [diff] [review]:
-----------------------------------------------------------------

I think matt might be better equipped to answer whether this change is correct.
Attachment #800788 - Flags: review?(jmuizelaar) → review?(matt.woodrow)
Comment on attachment 800788 [details] [diff] [review]
Good patch

Review of attachment 800788 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/basic/BasicCompositor.cpp
@@ -483,5 @@
>      mDrawTarget->DrawSurface(source,
>                               Rect(0, 0, mWidgetSize.width, mWidgetSize.height),
>                               Rect(0, 0, mWidgetSize.width, mWidgetSize.height),
>                               DrawSurfaceOptions(),
> -                             DrawOptions());

We should just use CopySurface instead.
(Assignee)

Updated

5 years ago
Attachment #800788 - Flags: review?(matt.woodrow)
(Assignee)

Comment 4

5 years ago
Created attachment 801622 [details] [diff] [review]
CopySurface
Attachment #800788 - Attachment is obsolete: true
Attachment #801622 - Flags: review?(matt.woodrow)
Attachment #801622 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/39d27a8b3b3a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.