913329 - Glass is broken under win OMTC basic

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: Working proof of concept

OMTC Basic is missing some code from nsWindowGfx. Particularly for Glass clearing the DC is important.
http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindowGfx.cpp#397

I have a POC patch that fixes the issue but it clears more then we need. I need to find the right times to clear before landing this.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Good patch

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 800788 [details] [diff] [review]
Good patch

Review of attachment 800788 [details] [diff] [review]:
-----------------------------------------------------------------

I think matt might be better equipped to answer whether this change is correct.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 800788 [details] [diff] [review]
Good patch

Review of attachment 800788 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/basic/BasicCompositor.cpp
@@ -483,5 @@
>      mDrawTarget->DrawSurface(source,
>                               Rect(0, 0, mWidgetSize.width, mWidgetSize.height),
>                               Rect(0, 0, mWidgetSize.width, mWidgetSize.height),
>                               DrawSurfaceOptions(),
> -                             DrawOptions());

We should just use CopySurface instead.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: CopySurface

Comment 5

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39d27a8b3b3a

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/39d27a8b3b3a