Closed Bug 913366 Opened 7 years ago Closed 7 years ago

Improve strings and l10n comment in app-manager.properties

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

The current file is completely missing localization comments and has at least 2 strings with problems.

validator.invalidManifestJSON=The webapp manifest isn't a valid JSON file: %1$S at: %2$S

If I read the code right, variable should be swapped (%1$S is the url, %2$S the error message).

validator.missIconForMarketplace=app submission to the Marketplace needs at least an 128 icon

"an 128 icon" doesn't sound right to me, I guess adding pixel would make sense too.
Attachment #800640 - Flags: review?(paul)
Comment on attachment 800640 [details] [diff] [review]
bug913366v1.patch

Thank you Francesco.
Attachment #800640 - Flags: review?(paul) → review+
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/e18393335796
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [land-in-fx-team][fixed-in-fx-team]
Whiteboard: [land-in-fx-team][fixed-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e18393335796
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.