Permanent Orange: TEST-UNEXPECTED-FAIL | test_plugins.js | false == "askToActivate"

RESOLVED FIXED

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Unassigned)

Tracking

(Depends on: 1 bug, {intermittent-failure})

Trunk
intermittent-failure

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fix bug 814168 so we don't have to keep fixing click-to-play off by default issues])

(Reporter)

Description

5 years ago
We've been seeing this since some more click to play refactorings landed.

Rather than fix the bug directly (which is probably due to click to play being turned off for us), I propose we just complete fixing bug 814168 as that should help with reducing the possibilities for future perma-oranges, and I know Benjamin wants to adjust the whole click to play prefs anyway.

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_plugins.js | false == "askToActivate" - See following stack:
JS frame :: /builds/slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_plugins.js :: run_test_1/</< :: line 89
JS frame :: resource://gre/modules/AddonManager.jsm :: safeCall :: line 83
JS frame :: resource://gre/modules/AddonManager.jsm :: getAddonByID_safeCall :: line 1683
JS frame :: resource://gre/modules/PluginProvider.jsm :: PL_getAddon :: line 119
JS frame :: resource://gre/modules/AddonManager.jsm :: callProvider :: line 109
JS frame :: resource://gre/modules/AddonManager.jsm :: getAddonByID_nextObject :: line 1681
JS frame :: resource://gre/modules/AddonManager.jsm :: AOC_callNext :: line 184
JS frame :: resource://gre/modules/AddonManager.jsm :: getAddonByID_safeCall :: line 1685
JS frame :: resource://gre/modules/LightweightThemeManager.jsm :: LightweightThemeManager_getAddonByID :: line 363
JS frame :: resource://gre/modules/AddonManager.jsm :: callProvider :: line 109
JS frame :: resource://gre/modules/AddonManager.jsm :: getAddonByID_nextObject :: line 1681
JS frame :: resource://gre/modules/AddonManager.jsm :: AOC_callNext :: line 184
JS frame :: resource://gre/modules/AddonManager.jsm :: getAddonByID_safeCall :: line 1685
JS frame :: resource://gre/modules/XPIProvider.jsm :: getAddonByID_getVisibleAddonForID :: line 3437
JS frame :: resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js :: safeCallback/< :: line 152
JS frame :: resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js :: getRepositoryAddon :: line 133
JS frame :: resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js :: <TOP_LEVEL> :: line 1086
JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 568
JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 350
Comment hidden (Treeherder Robot)
(Reporter)

Comment 2

5 years ago
This was fixed by https://hg.mozilla.org/comm-central/rev/52cc604d695c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.