Closed Bug 913421 Opened 11 years ago Closed 11 years ago

[Gaia] Handling active FDN status in message app

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: steveck, Assigned: gerard-majax)

References

Details

(Keywords: feature, Whiteboard: [u=commsapps-user c=messaging p=0])

Attachments

(1 file)

User Story for active FDN in message app:

As a user, if I dial any number in the dialer or by selecting a contact in the contacts app, outside what is allowed as per the FDN list, I expect to be informed that FDN mode is active and call is not placed.

As a user I expect to be informed that FDN mode is active and call is not placed while sending SMS/MMS.


Precondition:

* SIM supports FDN
* FDN mode is active


Acceptance Criteria:

* Message is displayed to user if call can not be placed due to FDN restriction
* Message is displayed to user if SMS or MMS can not be sent due to FDN restrictions
* Any error messages are displayed to user
Blocks: 888919
No longer depends on: 840915, 888919, 889251
One issue needs to be confirmed. FDN is an mechanism saved in the SIM. However, sending MMS doesn't go through the SIM, WSP network instead. That means the FDN can only block sending SMS by nature.

Hi Joe, could you please confirm this issue with partners? Thanks!
Flags: needinfo?(jcheng)
this is fine. Dont apply to MMS - android seems to have that same note attached that MMS does not fall under FDN.
Flags: needinfo?(jcheng)
Got it! Thanks Wilfred.
I've tested the current behavior thanks to kaze's branch, and when trying to send a SMS:
 - first, yoy get a message stating that you don't have network coverage
 - then, the sms is in the list and shown with an exclamation mark on its side

I suppose this bug is regarding the first step ?
Flags: needinfo?(schung)
Yes, you need to apply gene's patch in bug 913436 and it will return error with correct error code. Current we only display "service unavalible..." while receiving the requesst error. We should check the error code and display the corresponding dialog in this case.
Flags: needinfo?(schung)
No longer blocks: koi-comms
Whiteboard: [MOZ][UCID:Comms8, FT:comms, KOI:P1], [u=commsapps-user c=dialer p=0][Sprint 2][Status: UX provided initial spec, Gaia working on it] → [u=commsapps-user c=messaging p=0]
Pointer to Github pull-request
Comment on attachment 802172 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12061

Please find attached a link to the github pull request that addresses this issue.


The UI has been cross checked by UX people (Ayman) and the displaying of recipients numbers each one by one on a newline is a UX requirement.
Attachment #802172 - Flags: review?(schung)
FYI we did a bunch of tests with Steve and Gene on Android devices, and it turns out sending SMS looks simply denied even if the recipient number is in the FDN list.
Assignee: nobody → lissyx+mozillians
Comment on attachment 802172 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12061

The patch looks good to me now, thanks for the fixing and update!
Attachment #802172 - Flags: review?(schung) → review+
Merged on master: https://github.com/mozilla-b2g/gaia/commit/e7c5330eb8952e3ed126628636a890f68410ded7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.