Closed Bug 913450 Opened 7 years ago Closed 7 years ago

Remove duplicated teardownModule() from testAddons_enableDisableExtension/

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set

Tracking

(firefox24 fixed)

RESOLVED FIXED
Tracking Status
firefox24 --- fixed

People

(Reporter: AndreeaMatei, Assigned: AndreeaMatei)

Details

Attachments

(1 file)

Somehow we ended up with 2 teardownModules in testAddons_enableDisableExtension/ tests, one simple and one with aModule parameter.

http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-beta/tests/functional/restartTests/testAddons_enableDisableExtension/test1.js

Not sure why cause I don't seem to find such a changeset, we first thought of bug  886811 but seems alright there.

Will add a patch shortly.
Attached patch teardown.patchSplinter Review
Removed the second method.
Assignee: nobody → andreea.matei
Status: NEW → ASSIGNED
Attachment #800768 - Flags: review?(andrei.eftimie)
Comment on attachment 800768 [details] [diff] [review]
teardown.patch

Review of attachment 800768 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Testrun: http://mozmill-crowd.blargon7.com/#/functional/report/fb97b6210ae70da1b9ace674457b4de9

Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/c5db4e89e35d (mozilla-beta)
Attachment #800768 - Flags: review?(andrei.eftimie)
Attachment #800768 - Flags: review+
Attachment #800768 - Flags: checkin+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.