913450 - Remove duplicated teardownModule() from testAddons_enableDisableExtension/

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Andreea Matei [:AndreeaMatei]]

Somehow we ended up with 2 teardownModules in testAddons_enableDisableExtension/ tests, one simple and one with aModule parameter.

http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-beta/tests/functional/restartTests/testAddons_enableDisableExtension/test1.js

Not sure why cause I don't seem to find such a changeset, we first thought of bug  886811 but seems alright there.

Will add a patch shortly.

Comment 1

[Andreea Matei [:AndreeaMatei]]

Attachment: teardown.patch

Removed the second method.

Comment 2

[Andrei Eftimie]

Ok so last merge had this duplicated:
http://hg.mozilla.org/qa/mozmill-tests/rev/eed4d1de6f98
http://hg.mozilla.org/qa/mozmill-tests/diff/eed4d1de6f98/tests/functional/restartTests/testAddons_enableDisableExtension/test1.js

We can probably safely remove it.

Comment 3

[Andrei Eftimie]

Comment on attachment 800768 [details] [diff] [review]
teardown.patch

Review of attachment 800768 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Testrun: http://mozmill-crowd.blargon7.com/#/functional/report/fb97b6210ae70da1b9ace674457b4de9

Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/c5db4e89e35d (mozilla-beta)