All users were logged out of Bugzilla on October 13th, 2018

[Cost Control] Grid numbers are too close to the left edge of screen

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: amylee, Assigned: mai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design, visual-tracking)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 800842 [details]
Usage_SD_HD.png

Hi, 

The numbers on the left of the grid are too close to the left edge of the screen in SD and HD versions. Can this be adjusted so there's more space on the left side?

Thanks
(Reporter)

Updated

5 years ago
blocking-b2g: hd? → ---
status-b2g-v1.1hd: ? → ---
(Reporter)

Updated

5 years ago
Summary: [SMS] Header graphic and tab not aligned → [Cost Control] Grid numbers are too close to the left edge of screen
(Assignee)

Comment 1

5 years ago
Hí José, 
could you give some feedback about this bug?
Regards
Flags: needinfo?(vittone)

Comment 2

5 years ago
Hi, 

I was checking the IxD specs and this issue seems to be a wrong implementation of the MB indicator. Please check the page 23 of the latest spec: https://mozilla.box.com/s/k3h8p2rm6ldgd7ogfurj

"MB and GB indicators only positioned at unit change" in this case the "0 B" can be replaced with "0 MB", is the same information but the spacing issue will be solved.
Flags: needinfo?(vittone)
(Assignee)

Updated

5 years ago
Assignee: nobody → mri
(Assignee)

Comment 3

5 years ago
Created attachment 8385276 [details] [review]
patch v1.0

In this patch I implement the following changes asked by José Vittone:
- Graph legend changes:
    * The unit showed on the first label (0) must be the same that the first scale step. Eg. Actual scale (0B - 620KB - 1.24MB - 1.86 - 2.48 - 3.1) --> New Scale (0KB - 620 - 1.24MB - 1.86 - 2.48 - 3.1).
    * The left legend must have a normal weight (400) the actual is 600.
    * The numbers on left side only have one decimal position when its value is lower than 10, otherwise the number must be represented without decimals. Eg. Actual scale (0B - 620KB - 1.24MB - 1.86 - 2.48 - 3.1) --> New Scale (0KB - 620 - 1.2MB - 1.9 - 2.5 - 3.1)
    * Now, not always the last vertical line of the right edge was drawn, this line must be drawn always.     
    * On the bottom of the chart, the months mus be capitalized. (its first letter as a upper-case letter and the remaining letters in lower case).
    * On the bottom of the chart, the today fontsize must be the same of the month legend.

- On the bottom of the graphic (toggle data): 
    * The letters are not showed completed, the tails on descending letters - "q, p, y" etc - disappear. (On both labels - "Mobile Usage" and "Wi-Fi Usage")

Salva, do you mind reviewing the patch?
Regards
Attachment #8385276 - Flags: review?(salva)

Comment 4

5 years ago
Created attachment 8385395 [details]
costcontrol-little-enhacenments.png

I've asked marina to implement some small visual deviations on cost control page. Please, take a look at the attached image.

A) there is a missing line on the right side of the graph. 

B) Today's label has a different font size and it should not.

B) & C) Following the visual specs, dates shouldn't be all caps. Instead they should be like “Mar 1”.

D) if you take a look that lower parts of the letters, they are been cut. For instance, take a look at letter "g".
Attachment #8385276 - Flags: review?(salva) → review?(jmcf)

Comment 5

5 years ago
Comment on attachment 8385276 [details] [review]
patch v1.0

We need another round, please ask me once it is ready
Attachment #8385276 - Flags: review?(jmcf)
(Assignee)

Comment 6

5 years ago
Comment on attachment 8385276 [details] [review]
patch v1.0

Updated the PR with your comments.
Attachment #8385276 - Flags: review?(jmcf)

Comment 7

5 years ago
Comment on attachment 8385276 [details] [review]
patch v1.0

thanks, merge once Travis is green
Attachment #8385276 - Flags: review?(jmcf) → review+
(Assignee)

Comment 8

5 years ago
Master: b38902e1dd66ce40d4c8cc818107a61df3baa98e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.