913556 - Firefox fails to build on PPC64: build_config.h:117:2: error: #error Please add support for your architecture in build/build_config.h

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Gustavo Luiz Duarte]

Firefox build fails on PPC64 with the following error message:

9:41.45 In file included from /home/buildbot/buildbot/slave/runtests/build/ipc/chromium/src/base/port.h:9:0,
 9:41.45                  from /home/buildbot/buildbot/slave/runtests/build/ipc/chromium/src/base/basictypes.h:12,
 9:41.45                  from ../../ipc/ipdl/_ipdlheaders/mozilla/dom/PContent.h:10,
 9:41.45                  from ../../ipc/ipdl/_ipdlheaders/mozilla/dom/PContentChild.h:9,
 9:41.45                  from ../../dist/include/mozilla/dom/ContentChild.h:11,
 9:41.45                  from /home/buildbot/buildbot/slave/runtests/build/dom/media/MediaManager.cpp:18:
 9:41.45 /home/buildbot/buildbot/slave/runtests/build/media/webrtc/trunk/build/build_config.h:117:2: error: #error Please add support for your architecture in build/build_config.h


For the full build log see: http://mozillaproject.osuosl.org:8010/builders/runtests/builds/249/steps/shell/logs/stdio

Comment 1

[Steve Singer (:stevensn)]

Attachment: add_ppc_to_webrtc_buildconfig.patch

Builds in ppc32 with this patch

It doesn't look like the ARCH_CPU_XXX_ENDIAN define is even used other places in webrtc WEBRTC_BIG/LITTLE_ENDIAN

Comment 2

[Gustavo Luiz Duarte]

I can confirm that applying the patch from comment #1 Firefox builds fine on PPC64.
Thanks Steve!

Comment 3

[Landry Breuil (:gaston)]

I faced a similar issue on openbsd/ppc, and after discussing it with jesup on irc, took the liberty to add all the missing 'supported' archs from bug #654056.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0c24be12ddb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0c24be12ddb