Closed
Bug 913573
Opened 12 years ago
Closed 12 years ago
CSS alignment issues in the new thimble user bar
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: kate)
Details
Attachments
(2 files)
Loading up the new thimble master in Chrome reveals a number of misalignments that we'll need to fix before we can push to prod. The linked image has several elements misaligned vertically ("eye" and "pencil" icon sit too high, the "sign out" text is too low, and the content panels seem to have a gap between the user/tool bar, and the actual HTML/preview panes.
Assignee | ||
Comment 1•12 years ago
|
||
Starting to merge some of the friendlycode stuff back in
Attachment #800924 -
Flags: review?(pomax)
Comment on attachment 800924 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/211
Still seeing the vertical gap in both Chrome and FF:
- http://i.imgur.com/rsBriaF.png
- http://i.imgur.com/YlnOX1N.png
Attachment #800924 -
Flags: review?(pomax) → review-
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → kate
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 800924 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/211
Forgot to remove the link to the removed css file
Attachment #800924 -
Flags: review- → review?(pomax)
Comment on attachment 800924 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/211
nice!
Attachment #800924 -
Flags: review?(pomax) → review+
Comment 5•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/ca23aafc6a7fcfa4b02e45664608f54948d8d1d4
bug 913573: Update header CSS
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•