91361 - Maybe breaking skins is not a good idea....

Status: RESOLVED INVALID

(Core :: XUL, defect)

Description

[Mark Anderson]

It occurs to me that since we have an opportunity now to prevent Netscape 6.1 
skins breaking on trunk builds due to the changes for bug 70748, we should take 
it.  The fix is really simple, and just involves adding a styling for <groupbox> 
to the CSS files in the branch that already style <titledbox>.  However, since I 
can't obtain a branch source tree (or at least there isn't one in latest-0.9.2), 
I can't do much about it, so I'm assigning it to hewitt.

Comment 1

[John Morrison]

I'm not sure what you have in mind, but as far as getting a branch build,
you can just pull the MOZILLA_0_9_2_BRANCH

On win32, just 'set MOZ_BRANCH=MOZILLA_0_9_2_BRANCH', and then pull
mozilla/client.mak, then use that to pull the tree. On *nix, (and I may
be slightly wrong here, since everytime I do this I have to relearn the 
latest way to do it) you can 'setenv MOZ_CO_TAG MOZILLA_0_9_2_BRANCH', 
pull mozilla/client.mk, then pull the tree. [On mac, I am clueless].

Comment 2

[Mark Anderson]

The main problem there is that my copy of Visual C++ hasn't shipped yet, so 
pulling the branch is a bit difficult for me. :)

The changes are really simple, though; any instance of "titledbox" (minus the 
quotes, of course) in CSS needs an equivalent groupbox styling.  Shouldn't 
really slow anything down (at least not in any measurable manner), especially 
since there are no <groupbox> tags on the branch.  It's just a compatibility 
measure (while the trunk is backwards compatible with <titledbox>, the branch is 
not forwards compatible with <groupbox>) to keep skins from breaking.

Alternatively, something could be put in any documents about skinning that to 
support Mozilla 1.0 as well as Netscape additional rules for <groupbox> will be 
necessary.

Comment 3

[Mark Anderson]

Well, since the branch candidate builds are already up, marking INVALID.  Skins 
were gonna break anyway; I just figured it wouldn't be this soon.

(Unless whoever documents how to make a theme for Netscape 6.1 wants to say 
something about this; the additions are really easy to make.)