Closed Bug 913666 Opened 6 years ago Closed 6 years ago

Simplify handling of cycle collector listeners

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(5 files, 1 obsolete file)

No description provided.
Depends on: 913881
The goal of this series of patches is to move all of the internal cycle collector logic relating to listeners into a single location, which can then be moved into BeginCollection.  This is useful because we only need that location at the very beginning of a cycle collection, and with ICC we can end up entering the CC in a variety of ways, so we want to tuck things that happen only at the start away in one location in code.
Attached patch part 4 with a less terrible diff (obsolete) — Splinter Review
I think it is a little tidier to log the CC roots in the same place we compute them.
This will make it easier to move this stuff around later.
Attachment #802517 - Flags: review?(bugs)
Attachment #802521 - Flags: review?(bugs)
Attachment #802514 - Flags: checkin-
Comment on attachment 802514 [details] [diff] [review]
part 4 with a less terrible diff

Never mind, the diff looks okay.
Attachment #802514 - Attachment is obsolete: true
Attachment #802517 - Flags: review?(bugs) → review+
Attachment #802519 - Flags: review?(bugs) → review+
Attachment #802521 - Flags: review?(bugs) → review+
Attachment #802522 - Flags: review?(bugs) → review+
Attachment #802524 - Flags: review?(bugs) → review+
You need to log in before you can comment on or make changes to this bug.