Simplify handling of cycle collector listeners

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla26
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Depends on: 913881
(Assignee)

Comment 2

5 years ago
The goal of this series of patches is to move all of the internal cycle collector logic relating to listeners into a single location, which can then be moved into BeginCollection.  This is useful because we only need that location at the very beginning of a cycle collection, and with ICC we can end up entering the CC in a variety of ways, so we want to tuck things that happen only at the start away in one location in code.
(Assignee)

Comment 3

5 years ago
Created attachment 802514 [details] [diff] [review]
part 4 with a less terrible diff
(Assignee)

Comment 4

5 years ago
Created attachment 802517 [details] [diff] [review]
part 1 - Move cycle collector root logging into ScanRoots.

I think it is a little tidier to log the CC roots in the same place we compute them.
This will make it easier to move this stuff around later.
Attachment #802517 - Flags: review?(bugs)
(Assignee)

Comment 5

5 years ago
Created attachment 802519 [details] [diff] [review]
part 2 - Log cycle collector garbage at the same time we log roots.
Attachment #802519 - Flags: review?(bugs)
(Assignee)

Comment 6

5 years ago
Created attachment 802521 [details] [diff] [review]
part 3 - Sink cycle collector listener selection into Collect.
(Assignee)

Comment 7

5 years ago
Created attachment 802522 [details] [diff] [review]
part 4 - Sink free floating code from nsCycleCollector::Collect into BeginCollection.
Attachment #802522 - Flags: review?(bugs)
(Assignee)

Comment 8

5 years ago
Created attachment 802524 [details] [diff] [review]
part 5 - Rename aListener to aManualListener.
Attachment #802524 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Attachment #802521 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Attachment #802514 - Flags: checkin-
(Assignee)

Comment 9

5 years ago
Comment on attachment 802514 [details] [diff] [review]
part 4 with a less terrible diff

Never mind, the diff looks okay.
Attachment #802514 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.