913666 - Simplify handling of cycle collector listeners

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

single platform try run: https://tbpl.mozilla.org/?tree=Try&rev=633297ed2418

Comment 2

[Andrew McCreight [:mccr8]]

The goal of this series of patches is to move all of the internal cycle collector logic relating to listeners into a single location, which can then be moved into BeginCollection.  This is useful because we only need that location at the very beginning of a cycle collection, and with ICC we can end up entering the CC in a variety of ways, so we want to tuck things that happen only at the start away in one location in code.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 4 with a less terrible diff

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Move cycle collector root logging into ScanRoots.

I think it is a little tidier to log the CC roots in the same place we compute them.
This will make it easier to move this stuff around later.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Log cycle collector garbage at the same time we log roots.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Sink cycle collector listener selection into Collect.

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Sink free floating code from nsCycleCollector::Collect into BeginCollection.

Comment 8

[Andrew McCreight [:mccr8]]

Attachment: part 5 - Rename aListener to aManualListener.

Comment 9

[Andrew McCreight [:mccr8]]

Comment on attachment 802514 [details] [diff] [review]
part 4 with a less terrible diff

Never mind, the diff looks okay.

Comment 10

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f083909509ae
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b7fb9b9c1283
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1dab5dad3be9
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8d949fc41ef1
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5766073a1f62

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f083909509ae
https://hg.mozilla.org/mozilla-central/rev/b7fb9b9c1283
https://hg.mozilla.org/mozilla-central/rev/1dab5dad3be9
https://hg.mozilla.org/mozilla-central/rev/8d949fc41ef1
https://hg.mozilla.org/mozilla-central/rev/5766073a1f62