913670 - Cu.evalInSandbox should use 1-based line numbering

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

If you have

  <script src="foo.js"></script>

and foo.js is

  console.log(Error().lineNumber);

you get 1 in the console.

The Debugger API checks that line numbers are 1 or greater: http://mxr.mozilla.org/mozilla-central/source/js/src/vm/Debugger.cpp#2366

However, Cu.evalInSandbox will make the first line number 0 if you pass in a url parameter but not a line number parameter. This is in conflict with the other behaviors and should be fixed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This would just need fixing in the evalInSandbox code, right?  Request an optional_argc in the IDL and default the lineNo to 1 if not passed...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Does this help?

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 800996 [details] [diff] [review]
Does this help?

Review of attachment 800996 [details] [diff] [review]:
-----------------------------------------------------------------

Tested it out and it LGTM.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff0b038942a

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/9ff0b038942a