Closed
Bug 913731
Opened 11 years ago
Closed 10 years ago
Separate save and publish
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: brett, Assigned: thecount)
References
Details
(Whiteboard: preworkweek)
Attachments
(1 file)
Similar to bug # 912696 in thimble, we need to separate "saving" from publishing.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #802561 -
Flags: review?(schranz.m)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 802561 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/200 Comments!
Attachment #802561 -
Flags: review?(schranz.m) → review-
|
||
Updated•11 years ago
|
Summary: Seperate save and publish → Separate save and publish
|
|
Assignee | |
Comment 3•11 years ago
|
||
Cannot land this if it is not enforced. So, implementing the front end is the last part of all this that needs to happen.
Depends on: 919710
|
Reporter | |
Updated•11 years ago
|
Whiteboard: mozfest
|
|
Reporter | |
Comment 4•11 years ago
|
||
as discussed in team meeting, pushing from mozfest milestone
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
|
||
Updated•11 years ago
|
Assignee: scott → schranz.m
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 7•11 years ago
|
||
lol
|
|
||
Updated•10 years ago
|
Assignee: schranz.m → nobody
Status: ASSIGNED → NEW
|
|
Reporter | |
Updated•10 years ago
|
Whiteboard: preworkweek
|
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 8•10 years ago
|
||
Comment on attachment 802561 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/200 Woo
Attachment #802561 -
Flags: review- → review?(schranz.m)
|
|
||
Comment 9•10 years ago
|
||
Comment on attachment 802561 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/200 Lint fails and a lot of comments. Some minor. I'll test this locally once that's done (I should probably also land bug 919710 first too, so I'm on it).
Attachment #802561 -
Flags: review?(schranz.m) → review-
|
|
Assignee | |
Comment 10•10 years ago
|
||
Comment on attachment 802561 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/200 Updated
Attachment #802561 -
Flags: review- → review?(schranz.m)
|
|
||
Comment 11•10 years ago
|
||
Comment on attachment 802561 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/200 The publish button needs to stay deactivated when either a save has been started/is happening and of course if a publish has started. One case where it is not is if I make a new project, hit Save or Publish and then hit publish multiple times afterwards while our "project dialog" is open. It will save and publish correctly but you will incorrectly be told of an error. Obviously we need these buttons to stay deactivated while waiting for responses from the server as well.
Attachment #802561 -
Flags: review?(schranz.m) → review-
|
|
Assignee | |
Updated•10 years ago
|
Attachment #802561 -
Flags: review- → review?(schranz.m)
|
|
||
Updated•10 years ago
|
Attachment #802561 -
Flags: review?(schranz.m) → review+
|
|
Assignee | |
Comment 12•10 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/2e35c9778399e2886299b2ec14ec416e6e320df8 Needs verification.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in
before you can comment on or make changes to this bug.
Description
•