Closed Bug 913756 Opened 6 years ago Closed 6 years ago

Text Selection Handles displayed from position in previously navigated screen

Categories

(Firefox for Android :: Text Selection, defect)

23 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: capella, Assigned: capella)

Details

Attachments

(1 file)

In current release version (v23) you can STR:

1) Open FF and navigate to http://m.slashdot.org/
2) Observe at top of page colored section (underlined / labelled) |Most Discussed|
3) Long tap text in the title of the |Most Discussed| article in that section
4) Observe text is highlit, text handles are displayed
5) Observe page then navigates forward to display that article, *text handles remain*
Attached patch bug913756 v0Splinter Review
In the release version of FF we recognize an "after-viewport-change" message but fail in _updateCacheForSelection() processing due to:

   1) The assumption that there's a valid selection still and we just need to update the handle position
   2) selection.getRangeAt(0) == null, something the code doesn't expect. The routine logs an |Exception... "Index or size is negative or greater than the allowed amount"| message, fails, and the handles are left hanging with SelectionHandler in status TYPE_SELECTION.

This situation also occurs in Nightly, but due to our recent improvements in this area involving the addition of the notifySelectionChanged() routine, we recognize and attempt to address the loss of the selection, but need one tweak to the shutdown code _clearSelection() to correctly solve the rangeCount == 0 problem.
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #801084 - Flags: review?(margaret.leibovic)
Comment on attachment 801084 [details] [diff] [review]
bug913756 v0

Review of attachment 801084 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch. Just to double check, the improvements that exposed this issue are just on Nightly, not Aurora, right?
Attachment #801084 - Flags: review?(margaret.leibovic) → review+
Recent improvements came through bug 864589 bug 903316 bug 907271 bug 908861 ... (I think that's all the relevant pre-reqs here though we recently also pushed bug 903871 and 906499).

Yes, all of these changes are in nightly, and no, none seem to be in my (now) current aurora repo.
https://hg.mozilla.org/mozilla-central/rev/2dc3f0600dce
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.