913814 - HTTP cache v2: check why test_304_responses.js is slow

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

seems like main thread is held for 5 seconds from some reason (maybe something with the MetadataWriteTimer::Notify)

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

- the problem was not at all with MetadataWriteTimer::Notify
- many things are using 5 seconds in the platform :)
- this time it was close of an idle connection (from the client side) that closed connection also on the server side that triggered GC that end up freeing the entry handle that ended up CacheEntry::OnWriterClosed that moved the test forward
- just added metaDataReady() call to the right place (where it has to be with the new API) and it's done


Thinking of whether Close on the new entry impl should call metaDataReady() or even setValid() to have better backward compat...

Comment 2

[Michal Novotny [:michal]]

Comment on attachment 803128 [details] [diff] [review]
v1

(In reply to Honza Bambas (:mayhemer) from comment #1)
> Thinking of whether Close on the new entry impl should call metaDataReady()
> or even setValid() to have better backward compat...

But we don't call Close() explicitly.

Comment 3

[Honza Bambas (:mayhemer)]

(In reply to Michal Novotny (:michal) from comment #2)
> Comment on attachment 803128 [details] [diff] [review]
> v1
> 
> (In reply to Honza Bambas (:mayhemer) from comment #1)
> > Thinking of whether Close on the new entry impl should call metaDataReady()
> > or even setValid() to have better backward compat...
> 
> But we don't call Close() explicitly.

Yeah, and close() will eventually be removed anyway.  Probably not a good idea to do it.  We will break add-ons compatibility anyway after bug 913828 lands and actually silently break it (by means of not giving the desired results in most cases) with bug 913806.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 803128 [details] [diff] [review]
v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd68636da74

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5dd68636da74