Closed Bug 913823 Opened 6 years ago Closed 3 years ago

HTTP cache v2: fix all now disabled network xpcshell tests

Categories

(Core :: Networking: Cache, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [cache2][necko-active])

Attachments

(1 file)

There are notes for each test why it has been disabled (the analyzes has already been done).

https://hg.mozilla.org/projects/gum/file/tip/netwerk/test/unit/xpcshell.ini
Search: CACHE2
Depends on: 917432
Depends on: 1011150
Only disabled net xpcshell tests are:
* test_bug651100.js - depends on bug 1007071
* test_bug654926.js - can be enabled right now
* test_bug712914_secinfo_validation.js - I am personally against cache checking the sec info sanity, so this test may be a candidate to be removed
* test_bug767025.js - some unused appcache functionality must be implemented in one of the new cache classes (bug 913823)
Blocks: cache2afterenable
No longer blocks: cache2enable
Depends on: 1007071
(In reply to Honza Bambas (:mayhemer) from comment #1)
> * test_bug767025.js - some unused appcache functionality must be implemented
> in one of the new cache classes

bad bug# - has to be bug 1011150
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Whiteboard: [cache2] → [cache2][necko-backlog]
Depends on: 1287487
Attached patch v1Splinter Review
- test_bug654926.js now works
- test_bug712914_secinfo_validation.js removed, since the functionality is not supported by cache2 ; http channel is doing it
Attachment #8772020 - Flags: review?(michal.novotny)
Whiteboard: [cache2][necko-backlog] → [cache2][necko-active]
Attachment #8772020 - Flags: review?(michal.novotny) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc148fa9498e
enable some net xpcshell tests that have been disabled because of cache2, r=michal
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bc148fa9498e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.